From 76e887f46d820651057cab3a59ff0c3399ba9bbb Mon Sep 17 00:00:00 2001
From: Jake McDermott <yo@jakemcdermott.me>
Date: Mon, 5 Nov 2018 20:04:16 -0500
Subject: [PATCH] highlight entire row on hover

---
 awx/ui/client/features/output/_index.less       | 14 ++++++++------
 awx/ui/client/features/output/render.service.js | 14 ++++++++------
 2 files changed, 16 insertions(+), 12 deletions(-)

diff --git a/awx/ui/client/features/output/_index.less b/awx/ui/client/features/output/_index.less
index d1132d9ec2..b6110eb773 100644
--- a/awx/ui/client/features/output/_index.less
+++ b/awx/ui/client/features/output/_index.less
@@ -72,11 +72,19 @@
     &-row {
         display: flex;
 
+        &:hover {
+            background-color: white;
+        }
+
         &:hover div {
             background-color: white;
         }
     }
 
+    &-row--clickable {
+        cursor: pointer;
+    }
+
     &-toggle {
         background-color: @at-gray-eb;
         color: @at-gray-848992;
@@ -112,12 +120,6 @@
         .at-mixin-event();
     }
 
-    &-event--host {
-        .at-mixin-event();
-
-        cursor: pointer;
-    }
-
     &-time {
         padding-right: 2ch;
         font-size: 12px;
diff --git a/awx/ui/client/features/output/render.service.js b/awx/ui/client/features/output/render.service.js
index 3f23f449ed..8598d6ba3e 100644
--- a/awx/ui/client/features/output/render.service.js
+++ b/awx/ui/client/features/output/render.service.js
@@ -347,6 +347,7 @@ function JobRenderService ($q, $compile, $sce, $window) {
         let tdToggle = '';
         let tdEvent = '';
         let classList = '';
+        let directives = '';
 
         if (record.isMissing) {
             return `<div id="${record.uuid}" class="at-Stdout-row">
@@ -373,10 +374,6 @@ function JobRenderService ($q, $compile, $sce, $window) {
                 tdToggle = `<div class="at-Stdout-toggle" ng-click="vm.toggleCollapse('${id}')"><i class="fa ${icon} can-toggle"></i></div>`;
             }
 
-            if (record.isClickable) {
-                tdEvent = `<div class="at-Stdout-event--host" ng-click="vm.showHostDetails('${record.id}', '${record.uuid}')"><span ng-non-bindable>${content}</span></div>`;
-            }
-
             if (record.time && record.line === ln) {
                 timestamp = `<span>${record.time}</span>`;
             }
@@ -404,11 +401,16 @@ function JobRenderService ($q, $compile, $sce, $window) {
             }
         }
 
+        if (record && record.isClickable) {
+            classList += ' at-Stdout-row--clickable';
+            directives = `ng-click="vm.showHostDetails('${record.id}', '${record.uuid}')"`;
+        }
+
         return `
-            <div id="${id}" class="at-Stdout-row ${classList}">
+            <div id="${id}" class="at-Stdout-row ${classList}" ${directives}>
                 ${tdToggle}
                 <div class="at-Stdout-line">${ln}</div>
-                ${tdEvent}
+                <div class="at-Stdout-event"><span ng-non-bindable>${content}</span></div>
                 <div class="at-Stdout-time">${timestamp}</div>
             </div>`;
     };