External-Mirrors/awx
2
0
Fork 0
mirror of https://github.com/ansible/awx.git synced 2026-05-20 07:17:40 -02:30
Code Issues Packages Projects Releases Wiki Activity

properly perform validation on encrypted survey defaults

Browse Source 
see: https://github.com/ansible/ansible-tower/issues/7764
This commit is contained in:
Ryan Petrello
2017-11-09 16:56:12 -05:00
parent 122142c040
commit 78961c8037
2 changed files with 29 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
awx/main/models/mixins.py
View File

@@ -163,6 +163,19 @@ class SurveyJobTemplateMixin(models.Model):
def _survey_element_validation(self, survey_element, data):
errors = []
# make a copy of the data to break references (so that we don't
# inadvertently expose unencrypted default passwords as we validate)
data = data.copy()
if all([
survey_element['type'] == "password",
data.get(survey_element['variable']) == '$encrypted$'
]):
# replace encrypted password defaults so we don't validate on
# $encrypted$
data[survey_element['variable']] = decrypt_value(
get_encryption_key('value', pk=None),
survey_element['default']
)
if survey_element['variable'] not in data and survey_element['required']:
errors.append("'%s' value missing" % survey_element['variable'])
elif survey_element['type'] in ["textarea", "text", "password"]: