External-Mirrors/awx
2
0
Fork 0
mirror of https://github.com/ansible/awx.git synced 2026-05-07 17:37:37 -02:30
Code Issues Packages Projects Releases Wiki Activity

Add error handling to scm_version.py script (#13521)

Browse Source 
raise Exception in the case that return code is non-zero

this approach has shown itself to be the most consistently reliable across multiple ecosystems
This commit is contained in:
Alan Rominger
2023-05-10 14:20:56 -04:00
committed by GitHub
parent 06430741ab
commit 85e7189ee3
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
tools/scripts/scm_version.py
View File

@@ -1,7 +1,6 @@
import os import os
import sys import sys
import subprocess import subprocess
import traceback
try: try:
from setuptools_scm import get_version from setuptools_scm import get_version
@@ -9,8 +8,13 @@ except ModuleNotFoundError:
sys.stderr.write("Unable to import setuptools-scm, attempting to install now...\n") sys.stderr.write("Unable to import setuptools-scm, attempting to install now...\n")
os.environ['PIP_DISABLE_PIP_VERSION_CHECK'] = '1' os.environ['PIP_DISABLE_PIP_VERSION_CHECK'] = '1'
subprocess.check_output([sys.executable, '-m', 'ensurepip']) COMMANDS = ([sys.executable, '-m', 'ensurepip'], [sys.executable, '-m', 'pip', 'install', 'setuptools-scm'])
subprocess.check_output([sys.executable, '-m', 'pip', 'install', 'setuptools-scm']) for cmd in COMMANDS:
# capture_output because we only want to print version to stdout if successful
result = subprocess.run(cmd, capture_output=True)
if result.returncode:
# failed, we have no version, so print output so that users can debug
raise Exception(f'\nCommand `{" ".join(cmd)}` failed (rc={result.returncode}).\n\nstdout:\n{result.stdout}\n\nstderr:\n{result.stderr}')
from setuptools_scm import get_version from setuptools_scm import get_version