From 86a6e5ee6353b7b4bb545f344a3920733090e068 Mon Sep 17 00:00:00 2001
From: John Mitchell <jlmitch5@ncsu.edu>
Date: Tue, 5 Sep 2017 12:29:07 -0400
Subject: [PATCH] fix ctit logging toggle from being showed for log types other
 than https

---
 .../client/src/configuration/configuration.controller.js   | 4 +++-
 .../system-form/sub-forms/system-logging.form.js           | 3 ++-
 awx/ui/client/src/shared/form-generator.js                 | 7 ++++---
 3 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/awx/ui/client/src/configuration/configuration.controller.js b/awx/ui/client/src/configuration/configuration.controller.js
index 7d35be84e3..72cae0f2d2 100644
--- a/awx/ui/client/src/configuration/configuration.controller.js
+++ b/awx/ui/client/src/configuration/configuration.controller.js
@@ -394,7 +394,9 @@ export default [
                             // Default AD_HOC_COMMANDS to an empty list
                             payload[key] = $scope[key].value || [];
                         } else {
-                            payload[key] = $scope[key].value;
+                            if ($scope[key]) {
+                                payload[key] = $scope[key].value;
+                            }
                         }
                     }
                 } else if($scope.configDataResolve[key].type === 'list' && $scope[key] !== null) {
diff --git a/awx/ui/client/src/configuration/system-form/sub-forms/system-logging.form.js b/awx/ui/client/src/configuration/system-form/sub-forms/system-logging.form.js
index ac585102bc..8ae268c762 100644
--- a/awx/ui/client/src/configuration/system-form/sub-forms/system-logging.form.js
+++ b/awx/ui/client/src/configuration/system-form/sub-forms/system-logging.form.js
@@ -62,7 +62,8 @@
                 disableChooseOption: true
             },
             LOG_AGGREGATOR_VERIFY_CERT: {
-                type: 'toggleSwitch'
+                type: 'toggleSwitch',
+                ngShow: 'LOG_AGGREGATOR_PROTOCOL.value === "https"'
             }
          },
 
diff --git a/awx/ui/client/src/shared/form-generator.js b/awx/ui/client/src/shared/form-generator.js
index 3052788485..b65bf76184 100644
--- a/awx/ui/client/src/shared/form-generator.js
+++ b/awx/ui/client/src/shared/form-generator.js
@@ -762,9 +762,10 @@ angular.module('FormGenerator', [GeneratorHelpers.name, 'Utilities', listGenerat
 
                         html += label(labelOptions);
 
-                        html += `<div class="ScheduleToggle" ng-class="{'is-on': ${field.toggleSource}, 'ScheduleToggle--disabled': ${field.ngDisabled}}" aw-tool-tip=""
-                            data-placement="top">
-                            <button ng-show="${field.toggleSource}" class="ScheduleToggle-switch is-on" ng-click="toggleForm('${field.toggleSource}')"
+                        html += `<div class="ScheduleToggle" ng-class="{'is-on': ${field.toggleSource}, 'ScheduleToggle--disabled': ${field.ngDisabled}}" aw-tool-tip="" `
+                        html += (field.ngShow) ? "ng-show=\"" + field.ngShow + "\" " : "";
+                        html += `data-placement="top">`;
+                        html += `<button ng-show="${field.toggleSource}" class="ScheduleToggle-switch is-on" ng-click="toggleForm('${field.toggleSource}')"
                                 ng-disabled="${field.ngDisabled}">ON</button>
                             <button ng-show="!${field.toggleSource}" class="ScheduleToggle-switch" ng-click="toggleForm('${field.toggleSource}')"
                                 ng-disabled="${field.ngDisabled}">OFF</button>