From 540f8ab7d699ad9f52d5c6c581c74154544129a2 Mon Sep 17 00:00:00 2001
From: Jake McDermott <yo@jakemcdermott.me>
Date: Tue, 3 Dec 2019 15:23:02 -0500
Subject: [PATCH] Only show cred type test button to superusers.

Without a credential instance, plugin tests go through the credential
type (not credential) api. Since this endpoint is for superusers only,
we hide the test button when non-superusers are adding a new external
credential.
---
 .../credentials/add-edit-credentials.controller.js        | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/awx/ui/client/features/credentials/add-edit-credentials.controller.js b/awx/ui/client/features/credentials/add-edit-credentials.controller.js
index 63c54c9c32..3c9ea31fe9 100644
--- a/awx/ui/client/features/credentials/add-edit-credentials.controller.js
+++ b/awx/ui/client/features/credentials/add-edit-credentials.controller.js
@@ -156,7 +156,13 @@ function AddEditCredentialsController (
             if (credential.get('credential_type') === credentialType.get('id')) {
                 vm.inputSources.items = credential.get('related.input_sources.results');
             }
-            vm.isTestable = (isEditable && credentialType.get('kind') === 'external');
+
+            if (mode === 'add') {
+                vm.isTestable = (models.me.get('is_superuser') && credentialType.get('kind') === 'external');
+            } else {
+                vm.isTestable = (isEditable && credentialType.get('kind') === 'external');
+            }
+
             vm.getSubmitData = getSubmitData;
             vm.checkForm = check;