Merge branch 'release_2.4.2' into devel

* release_2.4.2: (23 commits)
  Updating 2.4.2 changelogs
  fix the connection check fix
  more robust check added to mongo db connection
  Adding a body to our OPTIONS requests fixes 415 error responses in IE11 and Edge.
  Don't hard-fail if default isn't defined on survey
  fixed custom login info bug
  Allow an org admin to delete project updates
  Disable elasticache instance gathering for aws
  Fix DEB builds by adding 2.4.2 to reprepro conf
  When the panel lists were consolidated down the list name was changed to 'all_jobs.'  When a job is clicked from the activity stream it should show the job list filtered down by ID.
  Rolled back job url change
  track modules on system tracking page by index
  correct spelling of consisting in help text
  Fixing up flake8
  The "job" href links in the activity stream don't point to the job details page.  This is an update to the jobs href to point to /#/jobs/(job.id).
  Wrapped the SourceChange call in a function so that it can be called without clearing the credential.  This fixes a bug where the credential was not showing up in the initial edit dialog even though the data was sent properly via the API.
  Revert change to Makefile, which was causing old .deb versions to be dropped from the repo
  Refactor scan_packages for os detection
  Remove stray debugging lines
  Add SUSE, OpenSuse and Debian to scan_packages
  ...

awx/ui/client/src/forms/JobTemplates.js

@@ -205,7 +205,7 @@ export default
                     column: 2,
                     awPopOver: "<p>Provide a comma separated list of tags.</p>\n" +
                         "<p>Tags are useful when you have a large playbook, and you want to run a specific part of a play or task.</p>" +
-                        "<p>For example, you might have a task consisiting of a long list of actions. Tag values can be assigned to each action. " +
+                        "<p>For example, you might have a task consisting of a long list of actions. Tag values can be assigned to each action. " +
                         "Suppose the actions have been assigned tag values of &quot;configuration&quot;, &quot;packages&quot; and &quot;install&quot;.</p>" +
                         "<p>If you just want to run the &quot;configuration&quot; and &quot;packages&quot; actions, you would enter the following here " +
                         "in the Job Tags field:</p>\n<blockquote>configuration,packages</blockquote>\n",

awx/ui/client/src/helpers/Groups.js

@@ -790,6 +790,11 @@ angular.module('GroupsHelper', [ 'RestServices', 'Utilities', listGenerator.name
                                ParseTypeChange({ scope: properties_scope, field_id: textareaID, onReady: waitStop });
                            }
 
+                           function initSourceChange() {
+                               parent_scope.showSchedulesTab = (mode === 'edit' &&  sources_scope.source && sources_scope.source.value!=="manual") ? true : false;
+                               SourceChange({ scope: sources_scope, form: SourceForm });
+                           }
+
                            // Set modal dimensions based on viewport width
                            ww = $(document).width();
                            wh = $('body').height();
@@ -1058,7 +1063,7 @@ angular.module('GroupsHelper', [ 'RestServices', 'Utilities', listGenerator.name
                                            }
                                        }
 
-                                       sources_scope.sourceChange(); //set defaults that rely on source value
+                                       initSourceChange();
 
                                        if (data.source_regions) {
                                            if (data.source === 'ec2' ||
@@ -1470,8 +1475,7 @@ angular.module('GroupsHelper', [ 'RestServices', 'Utilities', listGenerator.name
                                if (sources_scope.credential_name_api_error) {
                                    delete sources_scope.credential_name_api_error;
                                }
-                               parent_scope.showSchedulesTab = (mode === 'edit' &&  sources_scope.source && sources_scope.source.value!=="manual") ? true : false;
-                               SourceChange({ scope: sources_scope, form: SourceForm });
+                               initSourceChange();
                            };
 
                        };

awx/ui/client/src/helpers/Jobs.js

@@ -428,7 +428,7 @@ export default
                 // }, 300);
             });
 
-            if (base === 'jobs' && list.name === 'completed_jobs') {
+            if (base === 'jobs' && list.name === 'all_jobs') {
                 if ($routeParams.id__int) {
                     scope[list.iterator + 'SearchField'] = 'id';
                     scope[list.iterator + 'SearchValue'] = $routeParams.id__int;

awx/ui/client/src/rest/restServices.factory.js

@@ -258,7 +258,8 @@ export default
                         return $http({
                             method: 'OPTIONS',
                             url: this.url,
-                            headers: this.headers
+                            headers: this.headers,
+                            data: ''
                         });
                     } else {
                         return this.createResponse({

awx/ui/client/src/system-tracking/system-tracking.partial.html

@@ -54,7 +54,7 @@
                          'is-active': module.isActive,
                       }"
             ng-click="setActiveModule(module.name)"
-            ng-repeat="module in modules | orderBy: 'sortKey'">
+            ng-repeat="module in modules | orderBy: 'sortKey' track by $index">
             {{module.displayName}}
         </button>
     </nav>