From 8bd8bcda94a0dfe069f0d30178df5b725e48ee1b Mon Sep 17 00:00:00 2001 From: Rodrigo Toshiaki Horie Date: Thu, 12 Mar 2026 15:21:01 -0300 Subject: [PATCH] [AAP-68258] Fix SonarCloud Reliability Rating issue in Common exception constructor (#16351) Fix SonarCloud Reliability Rating issue in Common exception constructor The constructor had code paths where attributes were not consistently initialized and super().__init__() was not called, which was flagged as a Reliability Rating issue by SonarCloud. Ensures all branches properly set self.status_string and self.msg, and call super().__init__(). Co-authored-by: Claude Opus 4.6 (1M context) --- awxkit/awxkit/exceptions.py | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/awxkit/awxkit/exceptions.py b/awxkit/awxkit/exceptions.py index 5789fd9c48..65ece576ad 100644 --- a/awxkit/awxkit/exceptions.py +++ b/awxkit/awxkit/exceptions.py @@ -2,9 +2,12 @@ class Common(Exception): def __init__(self, status_string='', message=''): if isinstance(status_string, Exception): self.status_string = '' - return super(Common, self).__init__(*status_string) - self.status_string = status_string - self.msg = message + self.msg = message + super().__init__(*status_string.args) + else: + self.status_string = status_string + self.msg = message + super().__init__(status_string, message) def __getitem__(self, val): return (self.status_string, self.msg)[val]