From 8bf9dd038eb1cb647bb059d1c3d5b78601f41937 Mon Sep 17 00:00:00 2001 From: Kia Lam Date: Tue, 8 Mar 2022 12:58:04 -0800 Subject: [PATCH] Address review feedback. --- awx/ui/src/screens/TopologyView/ContentLoading.js | 1 - awx/ui/src/screens/TopologyView/MeshGraph.js | 4 ---- awx/ui/src/screens/TopologyView/utils/helpers.js | 2 +- 3 files changed, 1 insertion(+), 6 deletions(-) diff --git a/awx/ui/src/screens/TopologyView/ContentLoading.js b/awx/ui/src/screens/TopologyView/ContentLoading.js index cb67f6d34b..c4b07bf9f0 100644 --- a/awx/ui/src/screens/TopologyView/ContentLoading.js +++ b/awx/ui/src/screens/TopologyView/ContentLoading.js @@ -43,5 +43,4 @@ const ContentLoading = ({ className, progress }) => ( ); -export { ContentLoading as _ContentLoading }; export default ContentLoading; diff --git a/awx/ui/src/screens/TopologyView/MeshGraph.js b/awx/ui/src/screens/TopologyView/MeshGraph.js index 2d7700b45e..01ed117f7b 100644 --- a/awx/ui/src/screens/TopologyView/MeshGraph.js +++ b/awx/ui/src/screens/TopologyView/MeshGraph.js @@ -14,8 +14,6 @@ import { redirectToDetailsPage, getHeight, getWidth, - // generateRandomNodes, - // getRandomInt, } from './utils/helpers'; import webWorker from '../../util/webWorker'; import { @@ -34,14 +32,12 @@ const Loader = styled(ContentLoading)` background: white; `; function MeshGraph({ data, showLegend, zoom, setShowZoomControls }) { - // function MeshGraph({ showLegend, zoom }) { const [isNodeSelected, setIsNodeSelected] = useState(false); const [selectedNode, setSelectedNode] = useState(null); const [nodeDetail, setNodeDetail] = useState(null); const [simulationProgress, setSimulationProgress] = useState(null); const history = useHistory(); - // const data = generateRandomNodes(getRandomInt(4, 50)); const draw = () => { setShowZoomControls(false); const width = getWidth(SELECTOR); diff --git a/awx/ui/src/screens/TopologyView/utils/helpers.js b/awx/ui/src/screens/TopologyView/utils/helpers.js index cb185cbe61..f8dee9866c 100644 --- a/awx/ui/src/screens/TopologyView/utils/helpers.js +++ b/awx/ui/src/screens/TopologyView/utils/helpers.js @@ -32,7 +32,7 @@ export function renderNodeIcon(selectedNode) { return false; } -export async function redirectToDetailsPage(selectedNode, history) { +export function redirectToDetailsPage(selectedNode, history) { const { id: nodeId } = selectedNode; const constructedURL = `/instances/${nodeId}/details`; history.push(constructedURL);