diff --git a/__tests__/components/Breadcrumbs.test.jsx b/__tests__/components/Breadcrumbs.test.jsx index 71aa040560..eb1122d2da 100644 --- a/__tests__/components/Breadcrumbs.test.jsx +++ b/__tests__/components/Breadcrumbs.test.jsx @@ -53,7 +53,7 @@ describe('', () => { ]; routes.forEach(([location, crumbLength]) => { - const breadcrumbWrapper = mount( + breadcrumbWrapper = mount( ', () => { expect(breadcrumbWrapper.find('BreadcrumbItem')).toHaveLength(crumbLength); breadcrumbWrapper.unmount(); - }) - + }); }); - }); diff --git a/__tests__/components/Lookup.test.jsx b/__tests__/components/Lookup.test.jsx index eb41f62070..9081fd0dfd 100644 --- a/__tests__/components/Lookup.test.jsx +++ b/__tests__/components/Lookup.test.jsx @@ -40,7 +40,7 @@ describe('', () => { data={mockData} /> - ); + ); const searchItem = wrapper.find('.pf-c-input-group__text#search'); searchItem.first().simulate('click'); wrapper.find('input[type="checkbox"]').simulate('change'); diff --git a/src/pages/Organizations/components/OrganizationBreadcrumb.jsx b/src/pages/Organizations/components/OrganizationBreadcrumb.jsx deleted file mode 100644 index a8febba937..0000000000 --- a/src/pages/Organizations/components/OrganizationBreadcrumb.jsx +++ /dev/null @@ -1,88 +0,0 @@ -import React, { Fragment } from 'react'; -import { Trans } from '@lingui/macro'; -import { - PageSection, - PageSectionVariants, - Breadcrumb, - BreadcrumbItem, - BreadcrumbHeading -} from '@patternfly/react-core'; -import { - Link -} from 'react-router-dom'; - -import getTabName from '../utils'; - -const OrganizationBreadcrumb = ({ parentObj, organization, currentTab, location }) => { - const { light } = PageSectionVariants; - let breadcrumb = ''; - if (parentObj !== 'loading') { - const generateCrumb = (noLastLink = false) => ( - - {parentObj - .map(({ url, name }, index) => { - let elem; - if (noLastLink && parentObj.length - 1 === index) { - elem = ({name}); - } else { - elem = ( - - - {name} - - - ); - } - return elem; - }) - .reduce((prev, curr) => [prev, curr])} - - ); - - if (currentTab && currentTab !== 'details') { - breadcrumb = ( - - {generateCrumb()} - - {getTabName(currentTab)} - - - ); - } else if (location.pathname.indexOf('edit') > -1) { - breadcrumb = ( - - {generateCrumb()} - - Edit - - - ); - } else if (location.pathname.indexOf('add') > -1) { - breadcrumb = ( - - {generateCrumb()} - - Add - - - ); - } else { - breadcrumb = ( - - {generateCrumb(true)} - - ); - } - } - - return ( - - {breadcrumb} - - ); -}; - -export default OrganizationBreadcrumb; diff --git a/src/pages/Organizations/screens/OrganizationAdd.jsx b/src/pages/Organizations/screens/OrganizationAdd.jsx index eeff621393..ab116eece0 100644 --- a/src/pages/Organizations/screens/OrganizationAdd.jsx +++ b/src/pages/Organizations/screens/OrganizationAdd.jsx @@ -1,11 +1,8 @@ -import React, { Fragment } from 'react'; +import React from 'react'; import PropTypes from 'prop-types'; import { withRouter } from 'react-router-dom'; -import { Trans } from '@lingui/macro'; import { PageSection, - PageSectionVariants, - Title, Form, FormGroup, TextInput, @@ -22,8 +19,6 @@ import { ConfigContext } from '../../../context'; import Lookup from '../../../components/Lookup'; import AnsibleSelect from '../../../components/AnsibleSelect'; -const { light } = PageSectionVariants; - const format = (data) => { const results = data.results.map((result) => ({ id: result.id, @@ -132,72 +127,65 @@ class OrganizationAdd extends React.Component { const enabled = name.length > 0; // TODO: add better form validation return ( - - - - <Trans>Organization Add</Trans> - - - - - -
- - + + + + + + - + + + + + + + + + {({ custom_virtualenvs }) => ( + - - - - - - - - - {({ custom_virtualenvs }) => ( - - )} - - - - - - - - - - - - -
-
-
-
-
+ )} + + + + + + + + + + + + + + + + ); } }