Update tab content and related badge links

This commit is contained in:
Marliana Lara
2018-12-18 13:21:30 -05:00
parent e782be10b6
commit 913077c489
4 changed files with 8 additions and 20 deletions

View File

@@ -18,7 +18,7 @@ import getTabName from '../utils';
import '../tabs.scss'; import '../tabs.scss';
const DetailTab = ({ location, match, tab, currentTab, children, breadcrumb }) => { const Tab = ({ location, match, tab, currentTab, children, breadcrumb }) => {
const tabClasses = () => { const tabClasses = () => {
let classes = 'pf-c-tabs__item'; let classes = 'pf-c-tabs__item';
if (tab === currentTab) { if (tab === currentTab) {
@@ -93,13 +93,13 @@ const OrganizationDetail = ({
</Fragment> </Fragment>
); );
const detailTabs = (tabs) => ( const tabList = (tabs) => (
<I18n> <I18n>
{({ i18n }) => ( {({ i18n }) => (
<div className="pf-c-tabs" aria-label={i18n._(t`Organization detail tabs`)}> <div className="pf-c-tabs" aria-label={i18n._(t`Organization detail tabs`)}>
<ul className="pf-c-tabs__list"> <ul className="pf-c-tabs__list">
{tabs.map(tab => ( {tabs.map(tab => (
<DetailTab <Tab
key={tab} key={tab}
tab={tab} tab={tab}
location={location} location={location}
@@ -108,7 +108,7 @@ const OrganizationDetail = ({
breadcrumb={parentBreadcrumbObj} breadcrumb={parentBreadcrumbObj}
> >
{getTabName(tab)} {getTabName(tab)}
</DetailTab> </Tab>
))} ))}
</ul> </ul>
</div> </div>
@@ -120,7 +120,7 @@ const OrganizationDetail = ({
<PageSection variant={medium}> <PageSection variant={medium}>
<Card className="at-c-orgPane"> <Card className="at-c-orgPane">
<CardHeader> <CardHeader>
{detailTabs(['details', 'users', 'teams', 'admins', 'notifications'])} {tabList(['details', 'access', 'teams', 'notifications'])}
</CardHeader> </CardHeader>
<CardBody> <CardBody>
{(currentTab && currentTab !== 'details') ? ( {(currentTab && currentTab !== 'details') ? (

View File

@@ -14,7 +14,6 @@ export default ({
name, name,
userCount, userCount,
teamCount, teamCount,
adminCount,
isSelected, isSelected,
onSelect, onSelect,
detailUrl, detailUrl,
@@ -46,7 +45,7 @@ export default ({
</span> </span>
</div> </div>
<div className="pf-c-data-list__cell"> <div className="pf-c-data-list__cell">
<Link to={`${detailUrl}?tab=users`}> <Link to={`${detailUrl}?tab=access`}>
<Trans>Users</Trans> <Trans>Users</Trans>
</Link> </Link>
<Badge isRead> <Badge isRead>
@@ -62,14 +61,6 @@ export default ({
{teamCount} {teamCount}
{' '} {' '}
</Badge> </Badge>
<Link to={`${detailUrl}?tab=admins`}>
<Trans>Admins</Trans>
</Link>
<Badge isRead>
{' '}
{adminCount}
{' '}
</Badge>
</div> </div>
<div className="pf-c-data-list__cell" /> <div className="pf-c-data-list__cell" />
</li> </li>

View File

@@ -2,12 +2,10 @@ const getTabName = (tab) => {
let tabName = ''; let tabName = '';
if (tab === 'details') { if (tab === 'details') {
tabName = 'Details'; tabName = 'Details';
} else if (tab === 'users') { } else if (tab === 'access') {
tabName = 'Users'; tabName = 'Access';
} else if (tab === 'teams') { } else if (tab === 'teams') {
tabName = 'Teams'; tabName = 'Teams';
} else if (tab === 'admins') {
tabName = 'Admins';
} else if (tab === 'notifications') { } else if (tab === 'notifications') {
tabName = 'Notifications'; tabName = 'Notifications';
} }

View File

@@ -225,7 +225,6 @@ class Organizations extends Component {
parentBreadcrumb={parentBreadcrumb} parentBreadcrumb={parentBreadcrumb}
userCount={o.summary_fields.related_field_counts.users} userCount={o.summary_fields.related_field_counts.users}
teamCount={o.summary_fields.related_field_counts.teams} teamCount={o.summary_fields.related_field_counts.teams}
adminCount={o.summary_fields.related_field_counts.admins}
isSelected={selected.includes(o.id)} isSelected={selected.includes(o.id)}
onSelect={() => this.onSelect(o.id)} onSelect={() => this.onSelect(o.id)}
/> />