From 92117ae460200630983e4b4bbb9d9aaa7ba9afe8 Mon Sep 17 00:00:00 2001 From: Matthew Jones Date: Fri, 27 Jun 2014 13:20:41 -0400 Subject: [PATCH] Copy socket list in place to prevent a runtimeerror when the socket list gets updated in the middle of notifications Fixes https://trello.com/c/Q0bwCU9R/61-traceback-from-run-socketio-service --- awx/main/management/commands/run_socketio_service.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/awx/main/management/commands/run_socketio_service.py b/awx/main/management/commands/run_socketio_service.py index 0bb603625b..50602dc309 100644 --- a/awx/main/management/commands/run_socketio_service.py +++ b/awx/main/management/commands/run_socketio_service.py @@ -76,7 +76,7 @@ def notification_handler(bind_port, server): while True: message = handler_socket.recv_json() packet = dict(type='event', name=message['event'], endpoint=message['endpoint'], args=message) - for session_id, socket in server.sockets.iteritems(): + for session_id, socket in list(server.sockets.iteritems()): socket.send_packet(packet) class Command(NoArgsCommand):