From 95f5315fa350a99c6b034969c18d35aaba2d5676 Mon Sep 17 00:00:00 2001 From: Keith Grant Date: Mon, 1 Apr 2019 08:16:11 -0400 Subject: [PATCH] prevent console errors when code mirror parses invalid syntax --- .../code-mirror/modal/code-mirror-modal.directive.js | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/awx/ui/client/lib/components/code-mirror/modal/code-mirror-modal.directive.js b/awx/ui/client/lib/components/code-mirror/modal/code-mirror-modal.directive.js index a4051084b0..3c0ad60a07 100644 --- a/awx/ui/client/lib/components/code-mirror/modal/code-mirror-modal.directive.js +++ b/awx/ui/client/lib/components/code-mirror/modal/code-mirror-modal.directive.js @@ -17,10 +17,12 @@ function atCodeMirrorModalController ( } else if ($scope.disabled === 'false') { $scope.disabled = false; } - const editor = $(`${CodeMirrorModalID} .CodeMirror`)[0].CodeMirror; - const height = $(ModalHeight).height() - $(ModalHeader).height() - - $(ModalFooter).height() - 100; - editor.setSize('100%', height); + const editor = $(`${CodeMirrorModalID} .CodeMirror`)[0]; + if (editor) { + const height = $(ModalHeight).height() - $(ModalHeader).height() - + $(ModalFooter).height() - 100; + editor.CodeMirror.setSize('100%', height); + } } function toggle () {