diff --git a/awx/api/generics.py b/awx/api/generics.py index 605c824468..e8c6a1874b 100644 --- a/awx/api/generics.py +++ b/awx/api/generics.py @@ -2,7 +2,6 @@ # All Rights Reserved. # Python -from collections import OrderedDict import inspect import logging import time @@ -189,7 +188,7 @@ class GenericAPIView(generics.GenericAPIView, APIView): # Always remove read only fields from serializer. for name, field in serializer.fields.items(): if getattr(field, 'read_only', None): - del serializer.fields[name] + del serializer.fields[name] serializer._data = self.update_raw_data(serializer.data) return serializer diff --git a/awx/api/serializers.py b/awx/api/serializers.py index 1c8fd17bd8..0b0526a0ee 100644 --- a/awx/api/serializers.py +++ b/awx/api/serializers.py @@ -1251,7 +1251,7 @@ class InventorySourceOptionsSerializer(BaseSerializer): source = attrs.get('source', self.instance and self.instance.source or '') source_script = attrs.get('source_script', self.instance and self.instance.source_script or '') if source == 'custom': - if not source_script is None or source_script == '': + if source_script is None or source_script == '': errors['source_script'] = 'source_script must be provided' else: try: diff --git a/awx/api/views.py b/awx/api/views.py index aebe4e0a91..4b316ffd77 100644 --- a/awx/api/views.py +++ b/awx/api/views.py @@ -577,7 +577,7 @@ class AuthTokenView(APIView): # Always remove read only fields from serializer. for name, field in serializer.fields.items(): if getattr(field, 'read_only', None): - del serializer.fields[name] + del serializer.fields[name] serializer._data = self.update_raw_data(serializer.data) return serializer