External-Mirrors/awx
2
0
Fork 0
mirror of https://github.com/ansible/awx.git synced 2026-03-19 09:57:33 -02:30
Code Issues Packages Projects Releases Wiki Activity

register_peers will now raise errors if you attempt to reverse or loop

Browse Source
This commit is contained in:
Jeff Bradberry
2022-01-10 15:48:17 -05:00
parent 5ffe91f069
commit 9c9c1b4d3b
1 changed files with 12 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
awx/main/management/commands/register_peers.py
View File

@@ -35,6 +35,18 @@ class Command(BaseCommand):
if options['exact'] and options['disconnect']: if options['exact'] and options['disconnect']:
raise CommandError("The option --disconnect may not be used with --exact.") raise CommandError("The option --disconnect may not be used with --exact.")
# No 1-cycles
for collection in ('peers', 'disconnect', 'exact'):
if options['source'] in options[collection]:
raise CommandError(f"Source node {options['source']} may not also be in --{collection}.")
# No 2-cycles
if options['peers'] or options['exact']:
peers = set(options['peers'] or options['exact'])
incoming = set(InstanceLink.objects.filter(target=nodes[options['source']]).values_list('source__hostname', flat=True))
if peers & incoming:
raise CommandError(f"Source node {options['source']} cannot link to nodes already peering to it: {peers & incoming}.")
if options['peers']: if options['peers']:
missing_peers = set(options['peers']) - set(nodes) missing_peers = set(options['peers']) - set(nodes)
if missing_peers: if missing_peers: