158 paginated data list (#180)

* working: rename OrganizationTeamsList to PaginatedDataList

* convert org notifications list fully to PaginatedDataList

* update NotificationList tests

* refactor org access to use PaginatedDataList

* update tests for org access refactor; fix pagination & sorting

* restore Add Role functionality to Org roles

* fix displayed text when list of items is empty

* preserve query params when navigating through pagination

* fix bugs after RBAC rebase

* fix lint errors, fix add org access button

__tests__/util/qs.test.js

@@ -15,6 +15,14 @@ describe('qs (qs.js)', () => {
       });
   });
 
+  test('encodeQueryString omits null values', () => {
+    const vals = {
+      order_by: 'name',
+      page: null,
+    };
+    expect(encodeQueryString(vals)).toEqual('order_by=name');
+  });
+
   test('parseQueryString returns the expected queryParams', () => {
     [
       ['order_by=name&page=1&page_size=5', ['page', 'page_size'], { order_by: 'name', page: 1, page_size: 5 }],
@@ -26,4 +34,16 @@ describe('qs (qs.js)', () => {
         expect(actualQueryParams).toEqual(expectedQueryParams);
       });
   });
+
+  test('parseQueryString should strip leading "?"', () => {
+    expect(parseQueryString('?foo=bar&order_by=win')).toEqual({
+      foo: 'bar',
+      order_by: 'win',
+    });
+
+    expect(parseQueryString('foo=bar&order_by=?win')).toEqual({
+      foo: 'bar',
+      order_by: '?win',
+    });
+  });
 });

__tests__/util/strings.test.js

@@ -0,0 +1,34 @@
+import { pluralize, getArticle, ucFirst } from '../../src/util/strings';
+
+describe('string utils', () => {
+  describe('pluralize', () => {
+    test('should add an "s"', () => {
+      expect(pluralize('team')).toEqual('teams');
+    });
+
+    test('should add an "es"', () => {
+      expect(pluralize('class')).toEqual('classes');
+    });
+  });
+
+  describe('getArticle', () => {
+    test('should return "a"', () => {
+      expect(getArticle('team')).toEqual('a');
+      expect(getArticle('notification')).toEqual('a');
+    });
+
+    test('should return "an"', () => {
+      expect(getArticle('aardvark')).toEqual('an');
+      expect(getArticle('ear')).toEqual('an');
+      expect(getArticle('interest')).toEqual('an');
+      expect(getArticle('ogre')).toEqual('an');
+      expect(getArticle('umbrella')).toEqual('an');
+    });
+  });
+
+  describe('ucFirst', () => {
+    test('should capitalize first character', () => {
+      expect(ucFirst('team')).toEqual('Team');
+    });
+  });
+});