Add roles modal to org access list

This commit is contained in:
mabashian
2019-03-27 17:27:27 -04:00
parent 47bdbddbeb
commit a1002b03fa
19 changed files with 1322 additions and 24 deletions

View File

@@ -0,0 +1,260 @@
import React from 'react';
import { mount } from 'enzyme';
import { I18nProvider } from '@lingui/react';
import AddResourceRole from '../../src/components/AddRole/AddResourceRole';
describe('<SelectResourceStep />', () => {
const readUsers = jest.fn().mockResolvedValue({
data: {
count: 2,
results: [
{ id: 1, username: 'foo' },
{ id: 2, username: 'bar' }
]
}
});
const readTeams = jest.fn();
const createUserRole = jest.fn();
const createTeamRole = jest.fn();
const api = { readUsers, readTeams, createUserRole, createTeamRole };
const roles = {
admin_role: {
description: 'Can manage all aspects of the organization',
id: 1,
name: 'Admin'
},
execute_role: {
description: 'May run any executable resources in the organization',
id: 2,
name: 'Execute'
}
};
test('initially renders without crashing', () => {
mount(
<I18nProvider>
<AddResourceRole
api={api}
onClose={jest.fn()}
onSave={jest.fn()}
roles={roles}
/>
</I18nProvider>
);
});
test('handleRoleCheckboxClick properly updates state', () => {
const wrapper = mount(
<I18nProvider>
<AddResourceRole
api={api}
onClose={jest.fn()}
onSave={jest.fn()}
roles={roles}
/>
</I18nProvider>
).find('AddResourceRole');
wrapper.setState({
selectedRoleRows: [
{
description: 'Can manage all aspects of the organization',
name: 'Admin',
id: 1
}
]
});
wrapper.instance().handleRoleCheckboxClick({
description: 'Can manage all aspects of the organization',
name: 'Admin',
id: 1
});
expect(wrapper.state('selectedRoleRows')).toEqual([]);
wrapper.instance().handleRoleCheckboxClick({
description: 'Can manage all aspects of the organization',
name: 'Admin',
id: 1
});
expect(wrapper.state('selectedRoleRows')).toEqual([{
description: 'Can manage all aspects of the organization',
name: 'Admin',
id: 1
}]);
});
test('handleResourceCheckboxClick properly updates state', () => {
const wrapper = mount(
<I18nProvider>
<AddResourceRole
api={api}
onClose={jest.fn()}
onSave={jest.fn()}
roles={roles}
/>
</I18nProvider>
).find('AddResourceRole');
wrapper.setState({
selectedResourceRows: [
{
id: 1,
username: 'foobar'
}
]
});
wrapper.instance().handleResourceCheckboxClick({
id: 1,
username: 'foobar'
});
expect(wrapper.state('selectedResourceRows')).toEqual([]);
wrapper.instance().handleResourceCheckboxClick({
id: 1,
username: 'foobar'
});
expect(wrapper.state('selectedResourceRows')).toEqual([{
id: 1,
username: 'foobar'
}]);
});
test('clicking user/team cards updates state', () => {
const spy = jest.spyOn(AddResourceRole.prototype, 'handleResourceSelect');
const wrapper = mount(
<I18nProvider>
<AddResourceRole
onClose={jest.fn()}
onSave={jest.fn()}
api={api}
roles={roles}
/>
</I18nProvider>
).find('AddResourceRole');
const selectableCardWrapper = wrapper.find('SelectableCard');
expect(selectableCardWrapper.length).toBe(2);
selectableCardWrapper.first().simulate('click');
expect(spy).toHaveBeenCalledWith('users');
expect(wrapper.state('selectedResource')).toBe('users');
selectableCardWrapper.at(1).simulate('click');
expect(spy).toHaveBeenCalledWith('teams');
expect(wrapper.state('selectedResource')).toBe('teams');
});
test('readUsers and readTeams call out to corresponding api functions', () => {
const wrapper = mount(
<I18nProvider>
<AddResourceRole
api={api}
onClose={jest.fn()}
onSave={jest.fn()}
roles={roles}
/>
</I18nProvider>
).find('AddResourceRole');
wrapper.instance().readUsers({
foo: 'bar'
});
expect(readUsers).toHaveBeenCalledWith({
foo: 'bar'
});
wrapper.instance().readTeams({
foo: 'bar'
});
expect(readTeams).toHaveBeenCalledWith({
foo: 'bar'
});
});
test('handleResourceSelect clears out selected lists and sets selectedResource', () => {
const wrapper = mount(
<I18nProvider>
<AddResourceRole
api={api}
onClose={jest.fn()}
onSave={jest.fn()}
roles={roles}
/>
</I18nProvider>
).find('AddResourceRole');
wrapper.setState({
selectedResource: 'teams',
selectedResourceRows: [
{
id: 1,
username: 'foobar'
}
],
selectedRoleRows: [
{
description: 'Can manage all aspects of the organization',
id: 1,
name: 'Admin'
}
]
});
wrapper.instance().handleResourceSelect('users');
expect(wrapper.state()).toEqual({
selectedResource: 'users',
selectedResourceRows: [],
selectedRoleRows: []
});
wrapper.instance().handleResourceSelect('teams');
expect(wrapper.state()).toEqual({
selectedResource: 'teams',
selectedResourceRows: [],
selectedRoleRows: []
});
});
test('handleWizardSave makes correct api calls, calls onSave when done', async () => {
const handleSave = jest.fn();
const wrapper = mount(
<I18nProvider>
<AddResourceRole
api={api}
onClose={jest.fn()}
onSave={handleSave}
roles={roles}
/>
</I18nProvider>
).find('AddResourceRole');
wrapper.setState({
selectedResource: 'users',
selectedResourceRows: [
{
id: 1,
username: 'foobar'
}
],
selectedRoleRows: [
{
description: 'Can manage all aspects of the organization',
id: 1,
name: 'Admin'
},
{
description: 'May run any executable resources in the organization',
id: 2,
name: 'Execute'
}
]
});
await wrapper.instance().handleWizardSave();
expect(createUserRole).toHaveBeenCalledTimes(2);
expect(handleSave).toHaveBeenCalled();
wrapper.setState({
selectedResource: 'teams',
selectedResourceRows: [
{
id: 1,
name: 'foobar'
}
],
selectedRoleRows: [
{
description: 'Can manage all aspects of the organization',
id: 1,
name: 'Admin'
},
{
description: 'May run any executable resources in the organization',
id: 2,
name: 'Execute'
}
]
});
await wrapper.instance().handleWizardSave();
expect(createTeamRole).toHaveBeenCalledTimes(2);
expect(handleSave).toHaveBeenCalled();
});
});

View File

@@ -0,0 +1,17 @@
import React from 'react';
import { mount } from 'enzyme';
import CheckboxCard from '../../src/components/AddRole/CheckboxCard';
describe('<CheckboxCard />', () => {
let wrapper;
test('initially renders without crashing', () => {
wrapper = mount(
<CheckboxCard
name="Foobar"
itemId={5}
/>
);
expect(wrapper.length).toBe(1);
wrapper.unmount();
});
});

View File

@@ -0,0 +1,170 @@
import React from 'react';
import { mount } from 'enzyme';
import { I18nProvider } from '@lingui/react';
import SelectResourceStep from '../../src/components/AddRole/SelectResourceStep';
describe('<SelectResourceStep />', () => {
const columns = [
{ name: 'Username', key: 'username', isSortable: true }
];
afterEach(() => {
jest.restoreAllMocks();
});
test('initially renders without crashing', () => {
mount(
<I18nProvider>
<SelectResourceStep
columns={columns}
defaultSearchParams={{
is_superuser: false
}}
displayKey="username"
onRowClick={jest.fn()}
onSearch={jest.fn()}
sortedColumnKey="username"
/>
</I18nProvider>
);
});
test('fetches resources on mount', async () => {
const handleSearch = jest.fn().mockResolvedValue({
data: {
count: 2,
results: [
{ id: 1, username: 'foo' },
{ id: 2, username: 'bar' }
]
}
});
mount(
<I18nProvider>
<SelectResourceStep
columns={columns}
defaultSearchParams={{
is_superuser: false
}}
displayKey="username"
onRowClick={jest.fn()}
onSearch={handleSearch}
sortedColumnKey="username"
/>
</I18nProvider>
);
expect(handleSearch).toHaveBeenCalledWith({
is_superuser: false,
order_by: 'username',
page: 1,
page_size: 5
});
});
test('readResourceList properly adds rows to state', async () => {
const selectedResourceRows = [
{
id: 1,
username: 'foo'
}
];
const handleSearch = jest.fn().mockResolvedValue({
data: {
count: 2,
results: [
{ id: 1, username: 'foo' },
{ id: 2, username: 'bar' }
]
}
});
const wrapper = await mount(
<I18nProvider>
<SelectResourceStep
columns={columns}
defaultSearchParams={{
is_superuser: false
}}
displayKey="username"
onRowClick={jest.fn()}
onSearch={handleSearch}
selectedResourceRows={selectedResourceRows}
sortedColumnKey="username"
/>
</I18nProvider>
).find('SelectResourceStep');
await wrapper.instance().readResourceList({
page: 1,
order_by: '-username'
});
expect(handleSearch).toHaveBeenCalledWith({
is_superuser: false,
order_by: '-username',
page: 1
});
expect(wrapper.state('resources')).toEqual([
{ id: 1, username: 'foo' },
{ id: 2, username: 'bar' }
]);
});
test('handleSetPage calls readResourceList with correct params', () => {
const spy = jest.spyOn(SelectResourceStep.prototype, 'readResourceList');
const wrapper = mount(
<I18nProvider>
<SelectResourceStep
columns={columns}
displayKey="username"
onRowClick={jest.fn()}
onSearch={jest.fn()}
selectedResourceRows={[]}
sortedColumnKey="username"
/>
</I18nProvider>
).find('SelectResourceStep');
wrapper.setState({ sortOrder: 'descending' });
wrapper.instance().handleSetPage(2);
expect(spy).toHaveBeenCalledWith({ page: 2, page_size: 5, order_by: '-username' });
wrapper.setState({ sortOrder: 'ascending' });
wrapper.instance().handleSetPage(2);
expect(spy).toHaveBeenCalledWith({ page: 2, page_size: 5, order_by: 'username' });
});
test('handleSort calls readResourceList with correct params', () => {
const spy = jest.spyOn(SelectResourceStep.prototype, 'readResourceList');
const wrapper = mount(
<I18nProvider>
<SelectResourceStep
columns={columns}
displayKey="username"
onRowClick={jest.fn()}
onSearch={jest.fn()}
selectedResourceRows={[]}
sortedColumnKey="username"
/>
</I18nProvider>
).find('SelectResourceStep');
wrapper.instance().handleSort('username', 'descending');
expect(spy).toHaveBeenCalledWith({ page: 1, page_size: 5, order_by: '-username' });
wrapper.instance().handleSort('username', 'ascending');
expect(spy).toHaveBeenCalledWith({ page: 1, page_size: 5, order_by: 'username' });
});
test('clicking on row fires callback with correct params', () => {
const handleRowClick = jest.fn();
const wrapper = mount(
<I18nProvider>
<SelectResourceStep
columns={columns}
displayKey="username"
onRowClick={handleRowClick}
onSearch={jest.fn()}
selectedResourceRows={[]}
sortedColumnKey="username"
/>
</I18nProvider>
);
const selectResourceStepWrapper = wrapper.find('SelectResourceStep');
selectResourceStepWrapper.setState({
resources: [
{ id: 1, username: 'foo' }
]
});
const checkboxListItemWrapper = wrapper.find('CheckboxListItem');
expect(checkboxListItemWrapper.length).toBe(1);
checkboxListItemWrapper.first().find('input[type="checkbox"]').simulate('change', { target: { checked: true } });
expect(handleRowClick).toHaveBeenCalledWith({ id: 1, username: 'foo' });
});
});

View File

@@ -0,0 +1,63 @@
import React from 'react';
import { mount } from 'enzyme';
import SelectRoleStep from '../../src/components/AddRole/SelectRoleStep';
describe('<SelectRoleStep />', () => {
let wrapper;
const roles = {
project_admin_role: {
id: 1,
name: 'Project Admin',
description: 'Can manage all projects of the organization'
},
execute_role: {
id: 2,
name: 'Execute',
description: 'May run any executable resources in the organization'
}
};
const selectedRoles = [
{
id: 1,
name: 'Project Admin',
description: 'Can manage all projects of the organization'
}
];
const selectedResourceRows = [
{
id: 1,
name: 'foo'
}
];
test('initially renders without crashing', () => {
wrapper = mount(
<SelectRoleStep
roles={roles}
selectedResourceRows={selectedResourceRows}
selectedRoleRows={selectedRoles}
/>
);
expect(wrapper.length).toBe(1);
wrapper.unmount();
});
test('clicking role fires onRolesClick callback', () => {
const onRolesClick = jest.fn();
wrapper = mount(
<SelectRoleStep
onRolesClick={onRolesClick}
roles={roles}
selectedResourceRows={selectedResourceRows}
selectedRoleRows={selectedRoles}
/>
);
const CheckboxCards = wrapper.find('CheckboxCard');
expect(CheckboxCards.length).toBe(2);
CheckboxCards.first().prop('onSelect')();
expect(onRolesClick).toBeCalledWith({
id: 1,
name: 'Project Admin',
description: 'Can manage all projects of the organization'
});
wrapper.unmount();
});
});

View File

@@ -0,0 +1,27 @@
import React from 'react';
import { mount } from 'enzyme';
import SelectableCard from '../../src/components/AddRole/SelectableCard';
describe('<SelectableCard />', () => {
let wrapper;
const onClick = jest.fn();
test('initially renders without crashing when not selected', () => {
wrapper = mount(
<SelectableCard
onClick={onClick}
/>
);
expect(wrapper.length).toBe(1);
wrapper.unmount();
});
test('initially renders without crashing when selected', () => {
wrapper = mount(
<SelectableCard
isSelected
onClick={onClick}
/>
);
expect(wrapper.length).toBe(1);
wrapper.unmount();
});
});