From a130ac88dd34b20d51b4d2f88b28937a33603c94 Mon Sep 17 00:00:00 2001 From: Matthew Jones Date: Wed, 17 Dec 2014 22:39:11 -0500 Subject: [PATCH] Fix an bug where I wouldn't properly error out when survey validation would fail --- awx/api/views.py | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/awx/api/views.py b/awx/api/views.py index b05f113be6..b61a5fd6e1 100644 --- a/awx/api/views.py +++ b/awx/api/views.py @@ -1486,11 +1486,10 @@ class JobTemplateLaunch(GenericAPIView): request_data = {} else: request_data = request.DATA - if 'extra_vars' in request_data: - validation_errors = obj.survey_variable_validation(request_data['extra_vars']) - if validation_errors: - return Response(dict(errors=validation_errors), - status=status.HTTP_400_BAD_REQUEST) + validation_errors = obj.survey_variable_validation(request_data.get('extra_vars', {})) + if validation_errors: + return Response(dict(errors=validation_errors), + status=status.HTTP_400_BAD_REQUEST) if obj.credential is None and ('credential' not in request.DATA and 'credential_id' not in request.DATA): return Response(dict(errors="Credential not provided"), status=status.HTTP_400_BAD_REQUEST) new_job = obj.create_unified_job(**request.DATA)