From a1d1ddee2bfef1b09877f8e6971e09a637289cb7 Mon Sep 17 00:00:00 2001 From: Wayne Witzel III Date: Thu, 31 Mar 2016 09:58:23 -0400 Subject: [PATCH] cleaner get/create impl --- awx/main/models/rbac.py | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/awx/main/models/rbac.py b/awx/main/models/rbac.py index b1f3ca0a57..a8b2b58210 100644 --- a/awx/main/models/rbac.py +++ b/awx/main/models/rbac.py @@ -136,11 +136,8 @@ class Role(CommonModelNameNotUnique): @staticmethod def singleton(name): - try: - return Role.objects.get(singleton_name=name) - except Role.DoesNotExist: - ret = Role.objects.create(singleton_name=name, name=name) - return ret + role, _ = Role.objects.get_or_create(singleton_name=name, name=name) + return role def is_ancestor_of(self, role): return role.ancestors.filter(id=self.id).exists()