Fix eslint errors.

awx/ui/test/unit/components/job-details-split-jobs.unit.js

@@ -1,21 +1,20 @@
-'use strict';
 import moment from 'moment';
 
 describe('View: Job Details', () => {
-    let JobDetails,
+    let JobDetails;
-        scope,
+    let scope;
-        state,
+    let state;
-        OutputStrings,
+    let OutputStrings;
-        Prompt,
+    let Prompt;
-        filter,
+    let filter;
-        ProcessErrors,
+    let ProcessErrors;
-        Wait,
+    let Wait;
-        httpBackend,
+    let httpBackend;
-        ParseVariableString,
+    let ParseVariableString;
-        subscribe,
+    let subscribe;
-        OutputStatusService;
+    let OutputStatusService;
 
-    var mockData = {
+    let mockData = {
         job_slice_count: 2,
         job_slice_number: 2,
         labels: {
@@ -25,13 +24,11 @@ describe('View: Job Details', () => {
             SLICE_JOB_DETAILS: 'bar'
         }
     };
-    let resource = {
+    const resource = {
         id: '147',
         type: 'playbook',
         model: {
-            get: (obj) => {
+            get: (obj) => obj.split('.').reduce((i, o) => i && i[o] || null, mockData),
-                return obj.split('.').reduce((i,o) => i && i[o] || null, mockData);
-            },
             has: jasmine.createSpy('has'),
             options: jasmine.createSpy('options'),
         },
@@ -46,13 +43,11 @@ describe('View: Job Details', () => {
             },
             go: jasmine.createSpy('go'),
             includes: jasmine.createSpy('includes')
-        }
+        };
 
         OutputStrings = {
-            get: (obj) => {
+            get: (obj) => obj.split('.').reduce((i, o) => i && i[o] || null, mockData),
-                return obj.split('.').reduce((i,o) => i && i[o] || null, mockData);
+        };
-            },
-        }
 
         OutputStatusService = {
             subscribe: jasmine.createSpy('subscribe')
@@ -70,7 +65,7 @@ describe('View: Job Details', () => {
         $provide.value('ParseVariableString', angular.noop);
         $provide.value('OutputStatusService', OutputStatusService);
 
-        $provide.provider('$stateProvider', { '$get': function() { return function() {}; } });
+        $provide.provider('$stateProvider', { $get: jasmine.createSpy('$get'), });
         $provide.value('$stateExtender', { addState: jasmine.createSpy('addState'), });
         $provide.value('$stateRegistry', { register: jasmine.createSpy('regster'), });
         $provide.value('sanitizeFilter', angular.noop);
@@ -79,12 +74,16 @@ describe('View: Job Details', () => {
         $provide.value('longDateFilter', angular.noop);
     }));
 
-    beforeEach(angular.mock.inject(function($injector, $componentController, $rootScope, $httpBackend, _state_, _OutputStrings_, _ParseVariableString_, _Prompt_, _ProcessErrors_, _Wait_, _OutputStatusService_){
+    beforeEach(angular.mock.inject((
+        $injector, $componentController, $rootScope,
+        $httpBackend, _state_, _OutputStrings_, _ParseVariableString_, _Prompt_,
+        _ProcessErrors_, _Wait_, _OutputStatusService_
+    ) => {
         scope = $rootScope.$new();
         state = _state_;
         OutputStrings = _OutputStrings_;
         Prompt = _Prompt_;
-        filter = $injector.get("$filter");
+        filter = $injector.get('$filter');
         ProcessErrors = _ProcessErrors_;
         Wait = _Wait_;
         ParseVariableString = _ParseVariableString_;
@@ -94,16 +93,15 @@ describe('View: Job Details', () => {
         JobDetails = $componentController('atJobDetails', {
             $scope: scope,
             $state: state,
-            OutputStrings: OutputStrings,
+            OutputStrings,
-            ProcessErrors: ProcessErrors,
+            ProcessErrors,
-            Wait: Wait,
+            Wait,
-            Prompt: Prompt,
+            Prompt,
             $filter: filter,
-            Wait: Wait,
+            ParseVariableString,
-            ParseVariableString: ParseVariableString,
+            httpBackend,
-            httpBackend: httpBackend,
+            OutputStatusService,
-            OutputStatusService: OutputStatusService,
+        }, { resource });
-        }, {resource: resource});
         JobDetails.$onInit();
     }));
 
@@ -137,7 +135,7 @@ describe('View: Job Details', () => {
                 const result = JobDetails.sliceJobDetails;
                 expect(result).toBeNull();
             });
-            it('returns null if job_slice_count is undefined or null', () =>  {
+            it('returns null if job_slice_count is undefined or null', () => {
                 mockData = {
                     job_slice_count: null,
                     job_slice_number: 2,
@@ -152,7 +150,7 @@ describe('View: Job Details', () => {
                 const result = JobDetails.sliceJobDetails;
                 expect(result).toBeNull();
             });
-            it('returns null if job_slice_number is undefined or null', () =>  {
+            it('returns null if job_slice_number is undefined or null', () => {
                 mockData = {
                     job_slice_count: 2,
                     job_slice_number: null,
@@ -167,7 +165,7 @@ describe('View: Job Details', () => {
                 const result = JobDetails.sliceJobDetails;
                 expect(result).toBeNull();
             });
-            it('returns null if job is a non-sliced job', () =>  {
+            it('returns null if job is a non-sliced job', () => {
                 mockData = {
                     job_slice_count: 1,
                     job_slice_number: null,
@@ -184,4 +182,4 @@ describe('View: Job Details', () => {
             });
         });
     });
-});
+});

awx/ui/test/unit/components/jobs-list-split-jobs.unit.js

@@ -1,38 +1,36 @@
 describe('View: Split Jobs List', () => {
-    let JobList,
+    let JobList;
-        scope,
+    let scope;
-        state,
+    let state;
-        Dataset,
+    let Dataset;
-        resolvedModels,
+    let resolvedModels;
-        JobsStrings,
+    let JobsStrings;
-        QuerySet,
+    let QuerySet;
-        Prompt,
+    let Prompt;
-        filter,
+    let filter;
-        ProcessErrors,
+    let ProcessErrors;
-        Wait,
+    let Wait;
-        Rest,
+    let Rest;
-        SearchBasePath;
+    let SearchBasePath;
 
     beforeEach(angular.mock.module('at.features.jobs', ($provide) => {
         Dataset = {
             data: {
                 results: {}
             }
-        }
+        };
         state = {
             params: {
                 job_search: {}
             },
             go: jasmine.createSpy('go'),
             includes: jasmine.createSpy('includes')
-        }
+        };
         resolvedModels = [
             {
-                options: () => {
+                options: () => ['foo', 'bar'],
-                    return ["foo", "bar"];
-                }
             }
-        ]
+        ];
 
         ProcessErrors = jasmine.createSpy('ProcessErrors');
         Wait = jasmine.createSpy('Wait');
@@ -49,11 +47,14 @@ describe('View: Split Jobs List', () => {
         $provide.value('JobsStrings', angular.noop);
         $provide.value('QuerySet', angular.noop);
 
-        $provide.provider('$stateProvider', { '$get': function() { return function() {}; } });
+        $provide.provider('$stateProvider', { $get: jasmine.createSpy('$get'), });
         $provide.value('$stateExtender', { addState: jasmine.createSpy('addState'), });
     }));
 
-    beforeEach(angular.mock.inject(function($controller, $rootScope, _state_, _Dataset_, _resolvedModels_, _JobsStrings_, _QuerySet_, _Prompt_, _$filter_, _ProcessErrors_, _Wait_, _Rest_, _SearchBasePath_){
+    beforeEach(angular.mock.inject((
+        $controller, $rootScope, _state_, _Dataset_, _resolvedModels_, _JobsStrings_,
+        _QuerySet_, _Prompt_, _$filter_, _ProcessErrors_, _Wait_, _Rest_, _SearchBasePath_
+    ) => {
         scope = $rootScope.$new();
         state = _state_;
         Dataset = _Dataset_;
@@ -70,17 +71,16 @@ describe('View: Split Jobs List', () => {
         JobList = $controller('jobsListController', {
             $scope: scope,
             $state: state,
-            Dataset: Dataset,
+            Dataset,
-            resolvedModels: resolvedModels,
+            resolvedModels,
-            JobsStrings: JobsStrings,
+            JobsStrings,
-            ProcessErrors: ProcessErrors,
+            ProcessErrors,
-            QuerySet: QuerySet,
+            QuerySet,
-            Wait: Wait,
+            Wait,
-            Prompt: Prompt,
+            Prompt,
             $filter: filter,
-            Wait: Wait,
+            Rest,
-            Rest: Rest,
+            SearchBasePath,
-            SearchBasePath: SearchBasePath,
         });
     }));
 
@@ -92,36 +92,36 @@ describe('View: Split Jobs List', () => {
             expect(JobList.getSliceJobDetails).toBeDefined();
         });
         it('returns a string', () => {
-            let data = {
+            const data = {
                 job_slice_number: 1,
                 job_slice_count: 2
-            }
+            };
             const result = JobList.getSliceJobDetails(data);
             expect(result).toEqual('Slice Job 1/2');
         });
         it('returns null when data is null', () => {
-            let data = {
+            const data = {
                 job_slice_number: null,
                 job_slice_count: null
-            }
+            };
             const result = JobList.getSliceJobDetails(data);
             expect(result).toBeNull();
         });
         it('returns null when data is undefined', () => {
-            let data = {
+            const data = {
                 job_slice_number: undefined,
                 job_slice_count: undefined
-            }
+            };
             const result = JobList.getSliceJobDetails(data);
             expect(result).toBeNull();
         });
         it('returns null when job is not a sliced job', () => {
-            let data = {
+            const data = {
                 job_slice_number: null,
                 job_slice_count: 1
-            }
+            };
             const result = JobList.getSliceJobDetails(data);
             expect(result).toBeNull();
         });
     });
-});
+});