From a648ce5457b8cecccfabc2a8f8990d2666ea0b62 Mon Sep 17 00:00:00 2001 From: mabashian Date: Thu, 10 May 2018 13:00:32 -0400 Subject: [PATCH] Fixed bug checking for credentials to remove --- .../workflow-maker/workflow-maker.controller.js | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/awx/ui/client/src/templates/workflows/workflow-maker/workflow-maker.controller.js b/awx/ui/client/src/templates/workflows/workflow-maker/workflow-maker.controller.js index a4119b4a79..efe7bf6642 100644 --- a/awx/ui/client/src/templates/workflows/workflow-maker/workflow-maker.controller.js +++ b/awx/ui/client/src/templates/workflows/workflow-maker/workflow-maker.controller.js @@ -221,11 +221,15 @@ export default ['$scope', 'WorkflowService', 'GetBasePath', 'TemplatesService', }); }); - let credentialsToRemove = params.node.promptData.prompts.credentials.previousOverrides.filter(function(priorCred) { - return !credentialsNotInPriorCredentials.some(function(credNotInPrior) { - return priorCred.id === credNotInPrior.id; + let credentialsToRemove = []; + + if (_.has(params, 'node.promptData.prompts.credentials.previousOverrides')) { + credentialsToRemove = params.node.promptData.prompts.credentials.previousOverrides.filter(function(priorCred) { + return !credentialsNotInPriorCredentials.some(function(credNotInPrior) { + return priorCred.id === credNotInPrior.id; + }); }); - }); + } credentialsToAdd.forEach((credentialToAdd) => { credentialRequests.push({