build details url once

awx/ui_next/src/screens/Template/JobTemplateEdit/JobTemplateEdit.jsx

@@ -17,6 +17,11 @@ class JobTemplateEdit extends Component {
       error: '',
     };
 
+    const {
+      template: { id, type },
+    } = props;
+    this.detailsUrl = `/templates/${type}/${id}/details`;
+
     this.handleCancel = this.handleCancel.bind(this);
     this.handleSubmit = this.handleSubmit.bind(this);
     this.submitLabels = this.submitLabels.bind(this);
@@ -31,7 +36,7 @@ class JobTemplateEdit extends Component {
     try {
       await JobTemplatesAPI.update(id, { ...values });
       await Promise.all([this.submitLabels(newLabels, removedLabels)]);
-      history.push(`/templates/${type}/${id}/details`);
+      history.push(this.detailsUrl);
     } catch (error) {
       this.setState({ error });
     }
@@ -60,11 +65,8 @@ class JobTemplateEdit extends Component {
   }
 
   handleCancel() {
-    const {
+    const { history } = this.props;
-      template: { id, type },
+    history.push(this.detailsUrl);
-      history,
-    } = this.props;
-    history.push(`/templates/${type}/${id}/details`);
   }
 
   render() {
@@ -73,10 +75,7 @@ class JobTemplateEdit extends Component {
     const canEdit = template.summary_fields.user_capabilities.edit;
 
     if (!canEdit) {
-      const {
+      return <Redirect to={this.detailsUrl} />;
-        template: { id, type },
-      } = this.props;
-      return <Redirect to={`/templates/${type}/${id}/details`} />;
     }
 
     return (