From ae79f94a48bc45990d3088bb1250b85c169746b3 Mon Sep 17 00:00:00 2001 From: Lila Date: Tue, 29 Nov 2022 15:38:06 -0500 Subject: [PATCH] Decreased indentation of messaging block and removed credential_name since we are no longer using that var. --- awx/main/models/unified_jobs.py | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/awx/main/models/unified_jobs.py b/awx/main/models/unified_jobs.py index 01f8f084f1..d0158e6035 100644 --- a/awx/main/models/unified_jobs.py +++ b/awx/main/models/unified_jobs.py @@ -1345,19 +1345,18 @@ class UnifiedJob( # verify that any associated credentials aren't missing required field data missing_credential_inputs = [] - credential_name = "" for credential in self.credentials.all(): defined_fields = credential.credential_type.defined_fields for required in credential.credential_type.inputs.get('required', []): if required in defined_fields and not credential.has_input(required): missing_credential_inputs.append(required) - if missing_credential_inputs: - self.job_explanation = '{} cannot start because Credential {} does not provide one or more required fields ({}).'.format( - self._meta.verbose_name.title(), credential.name, ', '.join(sorted(missing_credential_inputs)) - ) - self.save(update_fields=['job_explanation']) - return (False, None) + if missing_credential_inputs: + self.job_explanation = '{} cannot start because Credential {} does not provide one or more required fields ({}).'.format( + self._meta.verbose_name.title(), credential.name, ', '.join(sorted(missing_credential_inputs)) + ) + self.save(update_fields=['job_explanation']) + return (False, None) needed = self.get_passwords_needed_to_start() try: