From b4007c7e043404563c71bdced968580b50ab05fe Mon Sep 17 00:00:00 2001
From: John Mitchell <jlmitch5@ncsu.edu>
Date: Wed, 13 Feb 2019 15:40:46 -0500
Subject: [PATCH] put FormGroup component in form instead of in AnsibleSelect
 component

---
 src/components/AnsibleSelect/AnsibleSelect.jsx   | 15 ++++++---------
 .../Organizations/screens/OrganizationAdd.jsx    | 16 ++++++++--------
 2 files changed, 14 insertions(+), 17 deletions(-)

diff --git a/src/components/AnsibleSelect/AnsibleSelect.jsx b/src/components/AnsibleSelect/AnsibleSelect.jsx
index 61c319639e..c8b7f142dd 100644
--- a/src/components/AnsibleSelect/AnsibleSelect.jsx
+++ b/src/components/AnsibleSelect/AnsibleSelect.jsx
@@ -1,7 +1,6 @@
 import React from 'react';
 
 import {
-  FormGroup,
   Select,
   SelectOption,
 } from '@patternfly/react-core';
@@ -33,17 +32,15 @@ class AnsibleSelect extends React.Component {
 
   render () {
     const { count } = this.state;
-    const { labelName, value, data, fieldId } = this.props;
+    const { value, data } = this.props;
     let elem;
     if (count > 1) {
       elem = (
-        <FormGroup label={labelName} fieldId={fieldId || 'ansible-select'}>
-          <Select value={value} id={`select-${fieldId}` || 'ansible-select-element'} onChange={this.onSelectChange} aria-label="Select Input">
-            {data.map((datum) => (
-              <SelectOption isDisabled={datum.disabled} key={datum} value={datum} label={datum} />
-            ))}
-          </Select>
-        </FormGroup>
+        <Select value={value} onChange={this.onSelectChange} aria-label="Select Input">
+          {data.map((datum) => (
+            <SelectOption isDisabled={datum.disabled} key={datum} value={datum} label={datum} />
+          ))}
+        </Select>
       );
     } else {
       elem = null;
diff --git a/src/pages/Organizations/screens/OrganizationAdd.jsx b/src/pages/Organizations/screens/OrganizationAdd.jsx
index 6a8ad53559..d1d02b9d41 100644
--- a/src/pages/Organizations/screens/OrganizationAdd.jsx
+++ b/src/pages/Organizations/screens/OrganizationAdd.jsx
@@ -135,14 +135,14 @@ class OrganizationAdd extends React.Component {
                 </FormGroup>
                 <ConfigContext.Consumer>
                   {({ custom_virtualenvs }) => (
-                    <AnsibleSelect
-                      fieldId="add-org-form-virtual-env"
-                      labelName="Ansible Environment"
-                      name="custom_virtualenv"
-                      value={custom_virtualenv}
-                      onChange={this.onFieldChange}
-                      data={custom_virtualenvs}
-                    />
+                    <FormGroup label="Ansible Environment" fieldId="add-org-form-custom-virtualenv">
+                      <AnsibleSelect
+                        name="custom_virtualenv"
+                        value={custom_virtualenv}
+                        onChange={this.onFieldChange}
+                        data={custom_virtualenvs}
+                      />
+                    </FormGroup>
                   )}
                 </ConfigContext.Consumer>
               </Gallery>