External-Mirrors/awx
2
0
Fork 0
mirror of https://github.com/ansible/awx.git synced 2026-02-23 05:55:59 -03:30
Code Issues Packages Projects Releases Wiki Activity

Make non-required params actually optional, fix idempotency issues

Browse Source
This commit is contained in:
beeankha
2020-02-25 23:51:26 -05:00
parent 1c4042340c
commit b532012748
8 changed files with 24 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
awx_collection/plugins/modules/tower_user.py
View File

@@ -118,7 +118,7 @@ def main():
first_name=dict(),
last_name=dict(),
password=dict(no_log=True),
email=dict(required=False),
email=dict(required=False, default=''),
superuser=dict(type='bool', default=False),
auditor=dict(type='bool', default=False),
state=dict(choices=['present', 'absent'], default='present'),
@@ -129,6 +129,7 @@ def main():
# Extract our parameters
state = module.params.get('state')
email = module.params.get('email')
# Create the data that gets sent for create and update
user_fields = {
@@ -136,10 +137,11 @@ def main():
'first_name': module.params.get('first_name'),
'last_name': module.params.get('last_name'),
'password': module.params.get('password'),
'email': module.params.get('email'),
'superuser': module.params.get('superuser'),
'auditor': module.params.get('auditor'),
}
if email is not None:
user_fields['email'] = email
# Attempt to look up user based on the provided username
user = module.get_one('users', **{