External-Mirrors/awx
2
0
Fork 0
mirror of https://github.com/ansible/awx.git synced 2026-02-26 23:46:05 -03:30
Code Issues Packages Projects Releases Wiki Activity

Avoid prop reference error when recreating survey

Browse Source 
The survey object is undefined when recreating a survey after deleting it.
Add optional chaining on survey fields to avoid prop reference error.
This commit is contained in:
Jake McDermott
2021-05-03 11:11:58 -04:00
parent 1c73407edf
commit b94a9c19e7
2 changed files with 4 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
awx/ui_next/src/screens/Template/Survey/SurveyQuestionAdd.jsx
View File

@@ -11,7 +11,7 @@ export default function SurveyQuestionAdd({ survey, updateSurvey }) {
const handleSubmit = async question => { const handleSubmit = async question => {
const formData = { ...question }; const formData = { ...question };
try { try {
if (survey.spec?.some(q => q.variable === formData.variable)) { if (survey?.spec?.some(q => q.variable === formData.variable)) {
setFormError( setFormError(
new Error( new Error(
`Survey already contains a question with variable named “${formData.variable}”` `Survey already contains a question with variable named “${formData.variable}”`
@@ -41,9 +41,7 @@ export default function SurveyQuestionAdd({ survey, updateSurvey }) {
formData.choices = choices.trim(); formData.choices = choices.trim();
} }
delete formData.formattedChoices; delete formData.formattedChoices;
const newSpec = survey?.spec ? survey.spec.concat(formData) : [formData];
const newSpec = survey.spec ? survey.spec.concat(formData) : [formData];
await updateSurvey(newSpec); await updateSurvey(newSpec);
history.push(match.url.replace('/add', '')); history.push(match.url.replace('/add', ''));
} catch (err) { } catch (err) {

4
awx/ui_next/src/screens/Template/TemplateSurvey.jsx
View File

@@ -53,8 +53,8 @@ function TemplateSurvey({ template, canEdit }) {
); );
const updateSurveySpec = spec => { const updateSurveySpec = spec => {
updateSurvey({ updateSurvey({
name: survey.name || '', name: survey?.name || '',
description: survey.description || '', description: survey?.description || '',
spec, spec,
}); });
}; };