Refactor Access List.

- Derive Team Roles without making extra API call.
- Consistent variable naming convention use camelCase.
- More informative error display.
This commit is contained in:
Kia Lam
2019-03-01 10:12:36 -05:00
parent a3a80bc23e
commit bf7e6201a2
5 changed files with 62 additions and 114 deletions

View File

@@ -10,12 +10,6 @@ const mockAPIAccessList = {
const mockAPIRoles = {
bar: 'baz',
};
const mockAPITeams = {
qux: 'quux',
};
const mockAPITeamRoles = {
quuz: 'quuz',
};
const mockGetOrganzationAccessList = jest.fn(() => (
Promise.resolve(mockAPIAccessList)
@@ -25,14 +19,6 @@ const mockGetUserRoles = jest.fn(() => (
Promise.resolve(mockAPIRoles)
));
const mockGetUserTeams = jest.fn(() => (
Promise.resolve(mockAPITeams)
));
const mockGetTeamRoles = jest.fn(() => (
Promise.resolve(mockAPITeamRoles)
));
describe('<OrganizationAccess />', () => {
test('initially renders succesfully', () => {
mount(
@@ -44,8 +30,6 @@ describe('<OrganizationAccess />', () => {
api={{
getOrganzationAccessList: jest.fn(),
getUserRoles: jest.fn(),
getUserTeams: jest.fn(),
getTeamRoles: jest.fn(),
}}
/>
</MemoryRouter>
@@ -62,8 +46,6 @@ describe('<OrganizationAccess />', () => {
api={{
getOrganzationAccessList: mockGetOrganzationAccessList,
getUserRoles: mockGetUserRoles,
getUserTeams: mockGetUserTeams,
getTeamRoles: mockGetTeamRoles,
}}
/>
</MemoryRouter>
@@ -72,9 +54,5 @@ describe('<OrganizationAccess />', () => {
expect(accessList).toEqual(mockAPIAccessList);
const userRoles = await wrapper.instance().getUserRoles();
expect(userRoles).toEqual(mockAPIRoles);
const userTeams = await wrapper.instance().getUserTeams();
expect(userTeams).toEqual(mockAPITeams);
const teamRoles = await wrapper.instance().getTeamRoles();
expect(teamRoles).toEqual(mockAPITeamRoles);
});
});