From c2a3c3b28597676f9153ef7d4e108eb8c3d6414e Mon Sep 17 00:00:00 2001 From: Gabe Muniz Date: Thu, 15 Dec 2022 09:41:55 -0500 Subject: [PATCH] The current behavior of workflow job templates is to pass in an empty string as scm_branch on allsaves and edits. This becomes problematic when using job templates/workflows which allow prompt on launch for scm_branch as it may override the scm_branch set for the individual workflow nodes to an empty string. That behavior limits the usefulness of prompting scm branch as it can no longer by selected while creating workflows as they'll be overwritten. --- .../Template/WorkflowJobTemplateAdd/WorkflowJobTemplateAdd.js | 2 ++ .../Template/WorkflowJobTemplateEdit/WorkflowJobTemplateEdit.js | 2 ++ 2 files changed, 4 insertions(+) diff --git a/awx/ui/src/screens/Template/WorkflowJobTemplateAdd/WorkflowJobTemplateAdd.js b/awx/ui/src/screens/Template/WorkflowJobTemplateAdd/WorkflowJobTemplateAdd.js index 8d6e7badc4..d6990920fa 100644 --- a/awx/ui/src/screens/Template/WorkflowJobTemplateAdd/WorkflowJobTemplateAdd.js +++ b/awx/ui/src/screens/Template/WorkflowJobTemplateAdd/WorkflowJobTemplateAdd.js @@ -24,6 +24,7 @@ function WorkflowJobTemplateAdd() { limit, job_tags, skip_tags, + scm_branch, ...templatePayload } = values; templatePayload.inventory = inventory?.id; @@ -32,6 +33,7 @@ function WorkflowJobTemplateAdd() { templatePayload.limit = limit === '' ? null : limit; templatePayload.job_tags = job_tags === '' ? null : job_tags; templatePayload.skip_tags = skip_tags === '' ? null : skip_tags; + templatePayload.scm_branch = scm_branch === '' ? null : scm_branch; const organizationId = organization?.id || inventory?.summary_fields?.organization.id; try { diff --git a/awx/ui/src/screens/Template/WorkflowJobTemplateEdit/WorkflowJobTemplateEdit.js b/awx/ui/src/screens/Template/WorkflowJobTemplateEdit/WorkflowJobTemplateEdit.js index d4929ec663..417451212a 100644 --- a/awx/ui/src/screens/Template/WorkflowJobTemplateEdit/WorkflowJobTemplateEdit.js +++ b/awx/ui/src/screens/Template/WorkflowJobTemplateEdit/WorkflowJobTemplateEdit.js @@ -30,6 +30,7 @@ function WorkflowJobTemplateEdit({ template }) { limit, job_tags, skip_tags, + scm_branch, ...templatePayload } = values; templatePayload.inventory = inventory?.id || null; @@ -38,6 +39,7 @@ function WorkflowJobTemplateEdit({ template }) { templatePayload.limit = limit === '' ? null : limit; templatePayload.job_tags = job_tags === '' ? null : job_tags; templatePayload.skip_tags = skip_tags === '' ? null : skip_tags; + templatePayload.scm_branch = scm_branch === '' ? null : scm_branch; const formOrgId = organization?.id || inventory?.summary_fields?.organization.id || null;