From d6c4c12c323ed299e8136fa66f5190510f165a18 Mon Sep 17 00:00:00 2001 From: AlanCoding Date: Tue, 2 Aug 2016 10:43:51 -0400 Subject: [PATCH] add API test coverage for empty tags and skip_tags --- .../functional/api/test_job_runtime_params.py | 14 ++++++++++++++ awx/main/tests/unit/test_network_credential.py | 4 ++-- 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/awx/main/tests/functional/api/test_job_runtime_params.py b/awx/main/tests/functional/api/test_job_runtime_params.py index bcbbb07dc9..af7d133c4c 100644 --- a/awx/main/tests/functional/api/test_job_runtime_params.py +++ b/awx/main/tests/functional/api/test_job_runtime_params.py @@ -115,6 +115,20 @@ def test_job_accept_prompted_vars(runtime_data, job_template_prompts, post, admi mock_job.signal_start.assert_called_once_with(**runtime_data) +@pytest.mark.django_db +@pytest.mark.job_runtime_vars +def test_job_accept_null_tags(job_template_prompts, post, admin_user, mocker): + job_template = job_template_prompts(True) + + mock_job = mocker.MagicMock(spec=Job, id=968) + + with mocker.patch('awx.main.models.unified_jobs.UnifiedJobTemplate.create_unified_job', return_value=mock_job): + with mocker.patch('awx.api.serializers.JobSerializer.to_representation'): + post(reverse('api:job_template_launch', args=[job_template.pk]), + {'job_tags': '', 'skip_tags': ''}, admin_user, expect=201) + + mock_job.signal_start.assert_called_once_with(job_tags='', skip_tags='') + @pytest.mark.django_db @pytest.mark.job_runtime_vars def test_job_accept_prompted_vars_null(runtime_data, job_template_prompts_null, post, rando, mocker): diff --git a/awx/main/tests/unit/test_network_credential.py b/awx/main/tests/unit/test_network_credential.py index 90f9959cfe..676a0c7f1f 100644 --- a/awx/main/tests/unit/test_network_credential.py +++ b/awx/main/tests/unit/test_network_credential.py @@ -41,8 +41,8 @@ def test_net_cred_ssh_agent(mocker, options): 'credential': None, 'cloud_credential': None, 'network_credential': Credential(**options), 'become_enabled': False, 'become_method': None, 'become_username': None, 'inventory': mocker.MagicMock(spec=Inventory, id=2), 'force_handlers': False, - 'limit': None, 'verbosity': None, 'job_tags': None, 'skip_tags': False, - 'start_at_task': False, 'pk': 1, 'launch_type': 'normal', 'job_template':None, + 'limit': None, 'verbosity': None, 'job_tags': None, 'skip_tags': None, + 'start_at_task': None, 'pk': 1, 'launch_type': 'normal', 'job_template':None, 'created_by': None, 'extra_vars_dict': None, 'project':None, 'playbook': 'test.yml'} mock_job = mocker.MagicMock(spec=Job, **mock_job_attrs)