[system_tracking] Remove truncation of fact values

This is a temporary fix until we can get a permanent fix to the
performance issues we have with rendering this much data to the DOM. For
more info see my comment on https://trello.com/c/QrbeaZfK.
This commit is contained in:
Joe Fiorini
2015-07-10 11:22:40 -04:00
parent 069bb69b00
commit c52ec1197b
4 changed files with 21 additions and 14 deletions

View File

@@ -1,4 +1,5 @@
/* jshint unused: vars */ /* jshint unused: vars */
import {addResizeListener, removeResizeListener} from 'tower/shared/element-resize';
function link($compile, scope, element, attrs) { function link($compile, scope, element, attrs) {
@@ -65,12 +66,14 @@ function link($compile, scope, element, attrs) {
// wanted to leave this as a regular event binding, but // wanted to leave this as a regular event binding, but
// was running into issues with the resized element getting // was running into issues with the resized element getting
// removed from the DOM after truncating! No idea why yet. // removed from the DOM after truncating! No idea why yet.
element.resize(function() { function resizeListener() {
addTitleIfWrapping(getText()); addTitleIfWrapping(getText());
}); }
addResizeListener(element[0], resizeListener);
scope.$watch('$destroy', function() { scope.$watch('$destroy', function() {
element.off('resize'); removeResizeListener(element[0], resizeListener);
}); });
} }

View File

@@ -2,3 +2,8 @@
overflow: hidden; overflow: hidden;
text-overflow: ellipsis; text-overflow: ellipsis;
} }
.u-wrappedText {
white-space: normal;
word-wrap: break-word;
}

View File

@@ -9,7 +9,7 @@
margin-bottom: 0.5em; margin-bottom: 0.5em;
align-items: center; align-items: center;
transition: background-color 100ms, border-color 100ms; transition: background-color 100ms, border-color 100ms;
max-height: 36px; // max-height: 36px;
border: solid 1px #fff; border: solid 1px #fff;
&:hover { &:hover {
background-color: #ebebeb; background-color: #ebebeb;
@@ -31,7 +31,6 @@
&-column { &-column {
padding: 8px; padding: 8px;
flex: 1 0 33%; flex: 1 0 33%;
white-space: nowrap;
align-self: flex-start; align-self: flex-start;
&--offsetLeft { &--offsetLeft {
margin-left: 33%; margin-left: 33%;

View File

@@ -28,20 +28,20 @@
<div class="FactDataTable-row FactDataTable-row--flexible" ng-if="group.containsValueArray"> <div class="FactDataTable-row FactDataTable-row--flexible" ng-if="group.containsValueArray">
<span class="FactDataTable-column">{{group.facts.keyName}}</span> <span class="FactDataTable-column">{{group.facts.keyName}}</span>
<span class="FactDataTable-column FactDataTable-columnArray"> <span class="FactDataTable-column FactDataTable-columnArray">
<span class="FactDataTable-columnMember" truncated-text ng-repeat="value in group.facts.value1"> <span class="FactDataTable-columnMember u-wrappedText" ng-repeat="value in group.facts.value1" style="position: relative;">
{{value}} {{value}}
</span> </span>
</span> </span>
<span class="FactDataTable-column FactDataTable-columnArray" ng-if="!singleResultView"> <span class="FactDataTable-column FactDataTable-columnArray" ng-if="!singleResultView">
<span class="FactDataTable-columnMember" truncated-text ng-repeat="value in group.facts.value2"> <span class="FactDataTable-columnMember u-wrappedText" ng-repeat="value in group.facts.value2" style="position: relative;">
{{value}} {{value}}
</span> </span>
</span> </span>
</div> </div>
<div class="FactDataTable-row" ng-if="!group.containsValueArray"> <div class="FactDataTable-row" ng-if="!group.containsValueArray">
<span class="FactDataTable-column">{{group.facts.keyName}}</span> <span class="FactDataTable-column">{{group.facts.keyName}}</span>
<span class="FactDataTable-column">{{group.facts.value1}}</span> <span class="FactDataTable-column u-wrappedText" style="position: relative;">{{group.facts.value1}}</span>
<span class="FactDataTable-column" ng-if="!singleResultView">{{group.facts.value2}}</span> <span class="FactDataTable-column u-wrappedText" ng-if="!singleResultView" style="position: relative;">{{group.facts.value2}}</span>
</div> </div>
</div> </div>
</div> </div>
@@ -60,13 +60,13 @@
<span class="FactDatum-keyName FactDataTable-column" ng-if="!fact.isArrayMember"> <span class="FactDatum-keyName FactDataTable-column" ng-if="!fact.isArrayMember">
{{fact.keyName}} {{fact.keyName}}
</span> </span>
<span class="FactDatum-keyName FactDataTable-column" ng-if="fact.isArrayMember"> <span class="FactDatum-keyName FactDataTable-column u-wrappedText" ng-if="fact.isArrayMember">
{{fact.keyPath[0]}}.{{fact.keyName}} {{fact.keyPath[0]}}.{{fact.keyName}}
</span> </span>
<span class="FactDatum-value FactDataTable-column" truncated-text> <span class="FactDatum-value FactDataTable-column u-wrappedText" style="position: relative;">
{{fact.value1}} {{fact.value1}}
</span> </span>
<span class="FactDatum-value FactDataTable-column" truncated-text ng-if="!singleResultView"> <span class="FactDatum-value FactDataTable-column u-wrappedText" ng-if="!singleResultView" style="position: relative;">
{{fact.value2}} {{fact.value2}}
</span> </span>
</div> </div>
@@ -78,10 +78,10 @@
<span class="FactDataTable-column FactDatum-keyName" ng-if="fact.isArrayMember"> <span class="FactDataTable-column FactDatum-keyName" ng-if="fact.isArrayMember">
{{fact.keyPath[0]}}.{{fact.keyName}} {{fact.keyPath[0]}}.{{fact.keyName}}
</span> </span>
<span class="FactDataTable-column FactDatum-value" truncated-text> <span class="FactDataTable-column FactDatum-value u-wrappedText" style="position: relative;">
{{fact.value1}} {{fact.value1}}
</span> </span>
<span class="FactDataTable-column FactDatum-value" truncated-text ng-if="!singleResultView"> <span class="FactDataTable-column FactDatum-value u-wrappedText" ng-if="!singleResultView" style="position: relative;">
{{fact.value2}} {{fact.value2}}
</span> </span>
</div> </div>