From f580b9f7d8b32787bfe7a300ee59fdb66d39fa0d Mon Sep 17 00:00:00 2001 From: Akita Noek Date: Tue, 21 Jun 2016 11:39:01 -0400 Subject: [PATCH 1/4] Hide the team role column and team tab from the add permissions modal on the Teams page --- .../access/addPermissions/addPermissions.directive.js | 3 +++ .../access/addPermissions/addPermissions.partial.html | 9 +++++++-- awx/ui/client/src/app.js | 3 +++ awx/ui/client/src/forms/Teams.js | 9 +-------- 4 files changed, 14 insertions(+), 10 deletions(-) diff --git a/awx/ui/client/src/access/addPermissions/addPermissions.directive.js b/awx/ui/client/src/access/addPermissions/addPermissions.directive.js index a9d21dfff8..7e7ea5b30b 100644 --- a/awx/ui/client/src/access/addPermissions/addPermissions.directive.js +++ b/awx/ui/client/src/access/addPermissions/addPermissions.directive.js @@ -16,6 +16,8 @@ export default controller: addPermissionsController, templateUrl: templateUrl('access/addPermissions/addPermissions'), link: function(scope, element, attrs, ctrl) { + console.info(attrs); + scope.withoutTeamPermissions = attrs.withoutTeamPermissions; scope.toggleFormTabs('users'); $("body").addClass("is-modalOpen"); @@ -24,6 +26,7 @@ export default Wait('start'); + scope.$broadcast("linkLists"); setTimeout(function() { diff --git a/awx/ui/client/src/access/addPermissions/addPermissions.partial.html b/awx/ui/client/src/access/addPermissions/addPermissions.partial.html index 85fd03d7f9..c2ca776768 100644 --- a/awx/ui/client/src/access/addPermissions/addPermissions.partial.html +++ b/awx/ui/client/src/access/addPermissions/addPermissions.partial.html @@ -23,10 +23,15 @@ 1 - Please select Users / Teams from the lists below. +
+ Please select Users / Teams from the lists below. +
+
+ Please select Users from the list below. +
-
+
diff --git a/awx/ui/client/src/app.js b/awx/ui/client/src/app.js index 1816888ce8..8300d7d09c 100644 --- a/awx/ui/client/src/app.js +++ b/awx/ui/client/src/app.js @@ -530,6 +530,9 @@ var tower = angular.module('Tower', [ $rootScope.addPermission = function (scope) { $compile("")(scope); }; + $rootScope.addPermissionWithoutTeamTab = function (scope) { + $compile("")(scope); + }; $rootScope.deletePermission = function (user, accessListEntry) { let entry = accessListEntry; diff --git a/awx/ui/client/src/forms/Teams.js b/awx/ui/client/src/forms/Teams.js index b8e9ba4f65..ad07a0ab2b 100644 --- a/awx/ui/client/src/forms/Teams.js +++ b/awx/ui/client/src/forms/Teams.js @@ -71,7 +71,7 @@ export default searchType: 'select', actions: { add: { - ngClick: "addPermission", + ngClick: "addPermissionWithoutTeamTab", label: 'Add', awToolTip: 'Add a permission', actionClass: 'btn List-buttonSubmit', @@ -92,13 +92,6 @@ export default noSort: true, class: 'col-lg-4 col-md-4 col-sm-4 col-xs-4', searchable: false - }, - team_roles: { - label: 'Team Roles', - type: 'team_roles', - noSort: true, - class: 'col-lg-5 col-md-5 col-sm-5 col-xs-4', - searchable: false } } }, From d43cb9fc9f70c311564697ac160d874486a4f643 Mon Sep 17 00:00:00 2001 From: Akita Noek Date: Tue, 21 Jun 2016 13:40:18 -0400 Subject: [PATCH 2/4] Hide the "Read" role as being something users can select --- awx/ui/client/src/access/addPermissions/roleSelect.directive.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/awx/ui/client/src/access/addPermissions/roleSelect.directive.js b/awx/ui/client/src/access/addPermissions/roleSelect.directive.js index c11dbe0e67..53bc191a6d 100644 --- a/awx/ui/client/src/access/addPermissions/roleSelect.directive.js +++ b/awx/ui/client/src/access/addPermissions/roleSelect.directive.js @@ -12,7 +12,7 @@ export default return { restrict: 'E', scope: false, - template: '', + template: '', link: function(scope, element, attrs, ctrl) { CreateSelect2({ element: '.roleSelect2', From d329d1807b61301cc63cfe039e27a65e809b02d1 Mon Sep 17 00:00:00 2001 From: Akita Noek Date: Tue, 21 Jun 2016 13:53:36 -0400 Subject: [PATCH 3/4] -debug log --- .../client/src/access/addPermissions/addPermissions.directive.js | 1 - 1 file changed, 1 deletion(-) diff --git a/awx/ui/client/src/access/addPermissions/addPermissions.directive.js b/awx/ui/client/src/access/addPermissions/addPermissions.directive.js index 7e7ea5b30b..57bb658788 100644 --- a/awx/ui/client/src/access/addPermissions/addPermissions.directive.js +++ b/awx/ui/client/src/access/addPermissions/addPermissions.directive.js @@ -16,7 +16,6 @@ export default controller: addPermissionsController, templateUrl: templateUrl('access/addPermissions/addPermissions'), link: function(scope, element, attrs, ctrl) { - console.info(attrs); scope.withoutTeamPermissions = attrs.withoutTeamPermissions; scope.toggleFormTabs('users'); From 0bde63730849aeec9d3f258ab06abcc3cb8a6cd3 Mon Sep 17 00:00:00 2001 From: Akita Noek Date: Wed, 22 Jun 2016 09:50:56 -0400 Subject: [PATCH 4/4] Hide the "Read" role key from the permissions modal --- .../src/access/addPermissions/addPermissions.partial.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/awx/ui/client/src/access/addPermissions/addPermissions.partial.html b/awx/ui/client/src/access/addPermissions/addPermissions.partial.html index c2ca776768..725a6e273e 100644 --- a/awx/ui/client/src/access/addPermissions/addPermissions.partial.html +++ b/awx/ui/client/src/access/addPermissions/addPermissions.partial.html @@ -72,7 +72,7 @@
+ ng-repeat="key in roleKey | filter:{name: '!Read'}">
{{ key.name }}