yamllint: Make all files in awx pass yamllint

This commit updates all files that weren't passing yamllint for them to
pass.

A new yamllint target has been added. One can run `tox -e yamllint` or
`yamllint -s .` locally to ensure yaml files are still passing.

This check will be enabled in the CI so it can get on every new
contributions, and prevent merging non-compliant code.

Signed-off-by: Yanis Guenane <yguenane@redhat.com>

awx/playbooks/check_isolated.yml

@@ -18,8 +18,8 @@
         src: "{{src}}/artifacts/"
         dest: "{{src}}/artifacts/"
         mode: pull
-        delete: yes
-        recursive: yes
+        delete: true
+        recursive: true
       when: ansible_kubectl_config is not defined
 
     - name: Copy daemon log from the isolated host
@@ -34,9 +34,9 @@
         src: "{{src}}/artifacts/"
         dest: "{{src}}/artifacts/"
         mode: pull
-        delete: yes
-        recursive: yes
-        set_remote_user: no
+        delete: true
+        recursive: true
+        set_remote_user: false
         rsync_opts:
           - "--rsh=$RSH"
       environment:
@@ -49,7 +49,7 @@
         src: "{{src}}/daemon.log"
         dest: "{{src}}/daemon.log"
         mode: pull
-        set_remote_user: no
+        set_remote_user: false
         rsync_opts:
           - "--rsh=$RSH"
       environment:

awx/playbooks/clean_isolated.yml

@@ -12,14 +12,14 @@
 
     - name: cancel the job
       command: "ansible-runner stop {{private_data_dir}}"
-      ignore_errors: yes
+      ignore_errors: true
 
     - name: remove build artifacts
       file: path="{{item}}" state=absent
       register: result
       with_items: "{{cleanup_dirs}}"
       until: result is succeeded
-      ignore_errors: yes
+      ignore_errors: true
       retries: 3
       delay: 5
 

awx/playbooks/project_update.yml

@@ -30,87 +30,87 @@
         - delete
 
     - block:
-      - name: update project using git
-        git:
-          dest: "{{project_path|quote}}"
-          repo: "{{scm_url}}"
-          version: "{{scm_branch|quote}}"
-          refspec: "{{scm_refspec|default(omit)}}"
-          force: "{{scm_clean}}"
-          accept_hostkey: "{{scm_accept_hostkey|default(omit)}}"
-        register: git_result
+        - name: update project using git
+          git:
+            dest: "{{project_path|quote}}"
+            repo: "{{scm_url}}"
+            version: "{{scm_branch|quote}}"
+            refspec: "{{scm_refspec|default(omit)}}"
+            force: "{{scm_clean}}"
+            accept_hostkey: "{{scm_accept_hostkey|default(omit)}}"
+          register: git_result
 
-      - name: Set the git repository version
-        set_fact:
-          scm_version: "{{ git_result['after'] }}"
-        when: "'after' in git_result"
+        - name: Set the git repository version
+          set_fact:
+            scm_version: "{{ git_result['after'] }}"
+          when: "'after' in git_result"
       tags:
         - update_git
 
     - block:
-      - name: update project using hg
-        hg:
-          dest: "{{project_path|quote}}"
-          repo: "{{scm_url|quote}}"
-          revision: "{{scm_branch|quote}}"
-          force: "{{scm_clean}}"
-        register: hg_result
+        - name: update project using hg
+          hg:
+            dest: "{{project_path|quote}}"
+            repo: "{{scm_url|quote}}"
+            revision: "{{scm_branch|quote}}"
+            force: "{{scm_clean}}"
+          register: hg_result
 
-      - name: Set the hg repository version
-        set_fact:
-          scm_version: "{{ hg_result['after'] }}"
-        when: "'after' in hg_result"
+        - name: Set the hg repository version
+          set_fact:
+            scm_version: "{{ hg_result['after'] }}"
+          when: "'after' in hg_result"
 
-      - name: parse hg version string properly
-        set_fact:
-          scm_version: "{{scm_version|regex_replace('^([A-Za-z0-9]+).*$', '\\1')}}"
+        - name: parse hg version string properly
+          set_fact:
+            scm_version: "{{scm_version|regex_replace('^([A-Za-z0-9]+).*$', '\\1')}}"
       tags:
         - update_hg
 
     - block:
-      - name: update project using svn
-        subversion:
-          dest: "{{project_path|quote}}"
-          repo: "{{scm_url|quote}}"
-          revision: "{{scm_branch|quote}}"
-          force: "{{scm_clean}}"
-          username: "{{scm_username|default(omit)}}"
-          password: "{{scm_password|default(omit)}}"
-        environment:
-          LC_ALL: 'en_US.UTF-8'
-        register: svn_result
+        - name: update project using svn
+          subversion:
+            dest: "{{project_path|quote}}"
+            repo: "{{scm_url|quote}}"
+            revision: "{{scm_branch|quote}}"
+            force: "{{scm_clean}}"
+            username: "{{scm_username|default(omit)}}"
+            password: "{{scm_password|default(omit)}}"
+          environment:
+            LC_ALL: 'en_US.UTF-8'
+          register: svn_result
 
-      - name: Set the svn repository version
-        set_fact:
-          scm_version: "{{ svn_result['after'] }}"
-        when: "'after' in svn_result"
+        - name: Set the svn repository version
+          set_fact:
+            scm_version: "{{ svn_result['after'] }}"
+          when: "'after' in svn_result"
 
-      - name: parse subversion version string properly
-        set_fact:
-          scm_version: "{{scm_version|regex_replace('^.*Revision: ([0-9]+).*$', '\\1')}}"
+        - name: parse subversion version string properly
+          set_fact:
+            scm_version: "{{scm_version|regex_replace('^.*Revision: ([0-9]+).*$', '\\1')}}"
       tags:
         - update_svn
 
     - block:
-      - name: Ensure the project directory is present
-        file:
-          dest: "{{project_path|quote}}"
-          state: directory
+        - name: Ensure the project directory is present
+          file:
+            dest: "{{project_path|quote}}"
+            state: directory
 
-      - name: Fetch Insights Playbook(s)
-        insights:
-          insights_url: "{{insights_url}}"
-          username: "{{scm_username}}"
-          password: "{{scm_password}}"
-          project_path: "{{project_path}}"
-          awx_license_type: "{{awx_license_type}}"
-          awx_version: "{{awx_version}}"
-        register: results
+        - name: Fetch Insights Playbook(s)
+          insights:
+            insights_url: "{{insights_url}}"
+            username: "{{scm_username}}"
+            password: "{{scm_password}}"
+            project_path: "{{project_path}}"
+            awx_license_type: "{{awx_license_type}}"
+            awx_version: "{{awx_version}}"
+          register: results
 
-      - name: Save Insights Version
-        set_fact:
-          scm_version: "{{results.version}}"
-        when: results is defined
+        - name: Save Insights Version
+          set_fact:
+            scm_version: "{{results.version}}"
+          when: results is defined
       tags:
         - update_insights
 
@@ -129,39 +129,39 @@
   tasks:
 
     - block:
-      - name: detect requirements.yml
-        stat: path={{project_path|quote}}/roles/requirements.yml
-        register: doesRequirementsExist
+        - name: detect requirements.yml
+          stat: path={{project_path|quote}}/roles/requirements.yml
+          register: doesRequirementsExist
 
-      - name: fetch galaxy roles from requirements.yml
-        command: ansible-galaxy install -r requirements.yml -p {{roles_destination|quote}}{{ ' -' + 'v' * ansible_verbosity if ansible_verbosity else '' }}
-        args:
-          chdir: "{{project_path|quote}}/roles"
-        register: galaxy_result
-        when: doesRequirementsExist.stat.exists
-        changed_when: "'was installed successfully' in galaxy_result.stdout"
-        environment:
-          ANSIBLE_FORCE_COLOR: False
+        - name: fetch galaxy roles from requirements.yml
+          command: ansible-galaxy install -r requirements.yml -p {{roles_destination|quote}}{{ ' -' + 'v' * ansible_verbosity if ansible_verbosity else '' }}
+          args:
+            chdir: "{{project_path|quote}}/roles"
+          register: galaxy_result
+          when: doesRequirementsExist.stat.exists
+          changed_when: "'was installed successfully' in galaxy_result.stdout"
+          environment:
+            ANSIBLE_FORCE_COLOR: false
 
       when: roles_enabled|bool
       tags:
         - install_roles
 
     - block:
-      - name: detect collections/requirements.yml
-        stat: path={{project_path|quote}}/collections/requirements.yml
-        register: doesCollectionRequirementsExist
+        - name: detect collections/requirements.yml
+          stat: path={{project_path|quote}}/collections/requirements.yml
+          register: doesCollectionRequirementsExist
 
-      - name: fetch galaxy collections from collections/requirements.yml
-        command: ansible-galaxy collection install -r requirements.yml -p {{collections_destination|quote}}{{ ' -' + 'v' * ansible_verbosity if ansible_verbosity else '' }}
-        args:
-          chdir: "{{project_path|quote}}/collections"
-        register: galaxy_collection_result
-        when: doesCollectionRequirementsExist.stat.exists
-        changed_when: "'Installing ' in galaxy_collection_result.stdout"
-        environment:
-          ANSIBLE_FORCE_COLOR: False
-          ANSIBLE_COLLECTIONS_PATHS: "{{ collections_destination }}"
+        - name: fetch galaxy collections from collections/requirements.yml
+          command: ansible-galaxy collection install -r requirements.yml -p {{collections_destination|quote}}{{ ' -' + 'v' * ansible_verbosity if ansible_verbosity else '' }}
+          args:
+            chdir: "{{project_path|quote}}/collections"
+          register: galaxy_collection_result
+          when: doesCollectionRequirementsExist.stat.exists
+          changed_when: "'Installing ' in galaxy_collection_result.stdout"
+          environment:
+            ANSIBLE_FORCE_COLOR: false
+            ANSIBLE_COLLECTIONS_PATHS: "{{ collections_destination }}"
 
       when:
         - "ansible_version.full is version_compare('2.8', '>=')"

awx/playbooks/run_isolated.yml

@@ -13,17 +13,17 @@
   tasks:
     - name: synchronize job environment with isolated host
       synchronize:
-        copy_links: yes
+        copy_links: true
         src: "{{ src }}"
         dest: "{{ dest }}"
       when: ansible_kubectl_config is not defined
 
     - name: synchronize job environment with remote job container
       synchronize:
-        copy_links: yes
+        copy_links: true
         src: "{{ src }}"
         dest: "{{ dest }}"
-        set_remote_user: no
+        set_remote_user: false
         rsync_opts:
           - "--rsh=$RSH"
       environment:
@@ -51,4 +51,4 @@
         content: "{{secret}}"
         path: "{{src}}/env/ssh_key"
       when: key.stat.exists
-      no_log: True
+      no_log: true

awx/playbooks/scan_facts.yml

@@ -1,3 +1,4 @@
+---
 - hosts: all
   vars:
     scan_use_checksum: false
@@ -33,4 +34,3 @@
         get_checksum: '{{ scan_use_checksum }}'
         recursive: '{{ scan_use_recursive }}'
       when: scan_file_paths is defined and ansible_os_family == "Windows"
-