yamllint: Make all files in awx pass yamllint

This commit updates all files that weren't passing yamllint for them to
pass.

A new yamllint target has been added. One can run `tox -e yamllint` or
`yamllint -s .` locally to ensure yaml files are still passing.

This check will be enabled in the CI so it can get on every new
contributions, and prevent merging non-compliant code.

Signed-off-by: Yanis Guenane <yguenane@redhat.com>

installer/build.yml

@@ -3,5 +3,5 @@
   hosts: all
   gather_facts: false
   roles:
-    - { role: image_build }
-    - { role: image_push, when: "docker_registry is defined" }
+    - {role: image_build}
+    - {role: image_push, when: "docker_registry is defined"}

installer/install.yml

@@ -2,8 +2,8 @@
 - name: Build and deploy AWX
   hosts: all
   roles:
-    - { role: check_vars }
-    - { role: image_build, when: "dockerhub_base is not defined" }
-    - { role: image_push, when: "docker_registry is defined and dockerhub_base is not defined" }
-    - { role: kubernetes, when: "openshift_host is defined or kubernetes_context is defined" }
-    - { role: local_docker, when: "openshift_host is not defined and kubernetes_context is not defined" }
+    - {role: check_vars}
+    - {role: image_build, when: "dockerhub_base is not defined"}
+    - {role: image_push, when: "docker_registry is defined and dockerhub_base is not defined"}
+    - {role: kubernetes, when: "openshift_host is defined or kubernetes_context is defined"}
+    - {role: local_docker, when: "openshift_host is not defined and kubernetes_context is not defined"}

installer/roles/check_vars/tasks/check_docker.yml

@@ -3,12 +3,12 @@
 - name: postgres_data_dir should be defined
   assert:
     that:
-    - postgres_data_dir is defined and postgres_data_dir != ''
+      - postgres_data_dir is defined and postgres_data_dir != ''
     msg: "Set the value of 'postgres_data_dir' in the inventory file."
   when: pg_hostname is not defined or pg_hostname == ''
 
 - name: host_port should be defined
   assert:
     that:
-    - host_port is defined and host_port != ''
+      - host_port is defined and host_port != ''
     msg: "Set the value of 'host_port' in the inventory file."

installer/roles/check_vars/tasks/check_openshift.yml

@@ -3,47 +3,47 @@
 - name: openshift_project should be defined
   assert:
     that:
-    - openshift_project is defined and openshift_project != ''
+      - openshift_project is defined and openshift_project != ''
     msg: "Set the value of 'openshift_project' in the inventory file."
 
 - name: openshift_user should be defined
   assert:
     that:
-    - openshift_user is defined and openshift_user != ''
+      - openshift_user is defined and openshift_user != ''
     msg: "Set the value of 'openshift_user' in the inventory file."
 
 - name: openshift_password or openshift_token should be defined
   assert:
     that:
-    - (openshift_password is defined and openshift_password != '') or
-      (openshift_token is defined and openshift_token != '')
+      - (openshift_password is defined and openshift_password != '') or
+        (openshift_token is defined and openshift_token != '')
     msg: "Set the value of 'openshift_password' or 'openshift_token' in the inventory file."
 
 - name: docker_registry should be defined if not using dockerhub
   assert:
     that:
-    - docker_registry is defined and docker_registry != ''
+      - docker_registry is defined and docker_registry != ''
     msg: "Set the value of 'docker_registry' in the inventory file."
   when: dockerhub_base is not defined
 
 - name: docker_registry_repository should be defined if not using dockerhub
   assert:
     that:
-    - docker_registry_repository is defined and docker_registry_repository != ''
+      - docker_registry_repository is defined and docker_registry_repository != ''
     msg: "Set the value of 'docker_registry_repository' in the inventory file."
   when: dockerhub_base is not defined
 
 - name: docker_registry_username should be defined if not using dockerhub
   assert:
     that:
-    - docker_registry_username is defined and docker_registry_username != ''
+      - docker_registry_username is defined and docker_registry_username != ''
     msg: "Set the value of 'docker_registry_username' in the inventory file."
   when: dockerhub_base is not defined
 
 - name: docker_registry_password should be defined
   assert:
     that:
-    - docker_registry_password is defined and docker_registry_password != ''
+      - docker_registry_password is defined and docker_registry_password != ''
     msg: "Set the value of 'docker_registry_password' in the inventory file."
   when: dockerhub_base is not defined
 

installer/roles/image_build/tasks/main.yml

@@ -37,7 +37,7 @@
   shell: make clean
   args:
     chdir: ..
-  ignore_errors: yes
+  ignore_errors: true
   when: not sdist.stat.exists
   delegate_to: localhost
 
@@ -46,7 +46,7 @@
     build:
       path: "{{ role_path }}/files"
       dockerfile: Dockerfile.sdist
-      pull: no
+      pull: false
       args:
         http_proxy: "{{ http_proxy | default('') }}"
         https_proxy: "{{ https_proxy | default('') }}"
@@ -178,7 +178,7 @@
     build:
       path: "{{ docker_base_path }}"
       dockerfile: Dockerfile
-      pull: no
+      pull: false
       args:
         http_proxy: "{{ http_proxy | default('') }}"
         https_proxy: "{{ https_proxy | default('') }}"
@@ -186,7 +186,7 @@
     name: "{{ web_image }}"
     tag: "{{ awx_version }}"
     source: 'build'
-    force_source: yes
+    force_source: true
   delegate_to: localhost
 
 - name: Build base task image
@@ -194,7 +194,7 @@
     build:
       path: "{{ docker_base_path }}"
       dockerfile: Dockerfile.task
-      pull: no
+      pull: false
       args:
         http_proxy: "{{ http_proxy | default('') }}"
         https_proxy: "{{ https_proxy | default('') }}"
@@ -202,7 +202,7 @@
     name: "{{ task_image }}"
     tag: "{{ awx_version }}"
     source: 'build'
-    force_source: yes
+    force_source: true
   delegate_to: localhost
 
 - name: Tag task and web images as latest

installer/roles/image_push/tasks/main.yml

@@ -4,7 +4,7 @@
     registry: "{{ docker_registry }}"
     username: "{{ docker_registry_username }}"
     password: "{{ docker_registry_password | quote }}"
-    reauthorize: yes
+    reauthorize: true
   when: docker_registry is defined and docker_registry_password is defined
   delegate_to: localhost
 
@@ -30,7 +30,7 @@
         name: "{{ web_image }}"
         repository: "{{ docker_registry }}/{{ docker_registry_repository }}/{{ web_image }}"
         tag: "{{ item }}"
-        push: yes
+        push: true
       with_items:
         - "latest"
         - "{{ awx_version }}"
@@ -40,7 +40,7 @@
         name: "{{ task_image }}"
         repository: "{{ docker_registry }}/{{ docker_registry_repository }}/{{ task_image }}"
         tag: "{{ item }}"
-        push: yes
+        push: true
       with_items:
         - "latest"
         - "{{ awx_version }}"

installer/roles/kubernetes/defaults/main.yml

@@ -1,6 +1,6 @@
 ---
 dockerhub_version: "{{ lookup('file', playbook_dir + '/../VERSION') }}"
-create_preload_data: True
+create_preload_data: true
 
 admin_user: 'admin'
 admin_email: 'root@localhost'
@@ -36,7 +36,7 @@ kubernetes_rabbitmq_image: "ansible/awx_rabbitmq"
 kubernetes_memcached_version: "latest"
 kubernetes_memcached_image: "memcached"
 
-openshift_pg_emptydir: no
+openshift_pg_emptydir: false
 openshift_pg_pvc_name: postgresql
 
 kubernetes_deployment_name: awx
@@ -55,6 +55,6 @@ custom_venvs_path: "/opt/custom-venvs"
 custom_venvs_python: "python2"
 
 ca_trust_bundle: "/etc/pki/tls/certs/ca-bundle.crt"
-rabbitmq_use_ssl: False
+rabbitmq_use_ssl: false
 
 container_groups_image: "ansible/ansible-runner"

installer/roles/kubernetes/tasks/backup.yml

@@ -55,7 +55,7 @@
           --port={{ pg_port | default('5432') }} \
           --username='{{ pg_username }}' \
           --dbname='{{ pg_database }}'" > {{ playbook_dir }}/tower-openshift-backup-{{ now }}/tower.db
-  no_log: yes
+  no_log: true
 
 - name: Copy inventory into backup directory
   copy:

installer/roles/kubernetes/tasks/kubernetes.yml

@@ -2,7 +2,7 @@
 - name: Get Namespace Detail
   shell: "kubectl get namespace {{ kubernetes_namespace }}"
   register: namespace_details
-  ignore_errors: yes
+  ignore_errors: true
 
 - name: Create AWX Kubernetes Project
   shell: "kubectl create namespace {{ kubernetes_namespace }}"
@@ -12,4 +12,3 @@
   set_fact:
     postgresql_service_name: "{{ kubernetes_deployment_name }}-postgresql"
   when: "pg_hostname is not defined or pg_hostname == ''"
-

installer/roles/kubernetes/tasks/main.yml

@@ -32,7 +32,7 @@
       {{ kubernetes_deployment_name }} \
       -n {{ kubernetes_namespace }} -o=jsonpath='{.status.replicas}'
   register: deployment_details
-  ignore_errors: yes
+  ignore_errors: true
 
 - name: Set expected post-deployment Replicas value
   set_fact:
@@ -48,7 +48,7 @@
 - name: Get Postgres Service Detail
   shell: "{{ kubectl_or_oc }} describe svc {{ postgresql_service_name }} -n {{ kubernetes_namespace }}"
   register: postgres_svc_details
-  ignore_errors: yes
+  ignore_errors: true
   when: "pg_hostname is not defined or pg_hostname == ''"
 
 - name: Deploy PostgreSQL (OpenShift)
@@ -72,7 +72,7 @@
           -e POSTGRESQL_VERSION=10 \
           -n {{ kubernetes_namespace }}
       register: openshift_pg_activate
-      no_log: yes
+      no_log: true
   when:
     - pg_hostname is not defined or pg_hostname == ''
     - postgres_svc_details is defined and postgres_svc_details.rc != 0
@@ -83,7 +83,7 @@
     - name: Template PostgreSQL Deployment (Kubernetes)
       set_fact:
         pg_values: "{{ lookup('template', 'postgresql-values.yml.j2') }}"
-      no_log: yes
+      no_log: true
 
     - name: Deploy and Activate Postgres (Kubernetes)
       shell: |
@@ -95,7 +95,7 @@
           --values - \
           stable/postgresql
       register: kubernetes_pg_activate
-      no_log: yes
+      no_log: true
   when:
     - pg_hostname is not defined or pg_hostname == ''
     - postgres_svc_details is defined and postgres_svc_details.rc != 0
@@ -206,7 +206,7 @@
     - 'configmap'
     - 'deployment'
     - 'secret'
-  no_log: yes
+  no_log: true
 
 - name: Apply Deployment
   shell: |
@@ -215,7 +215,7 @@
     - "{{ configmap }}"
     - "{{ deployment }}"
     - "{{ secret }}"
-  no_log: yes
+  no_log: true
 
 - name: Delete any existing management pod
   shell: |
@@ -249,21 +249,21 @@
     {{ kubectl_or_oc }} -n {{ kubernetes_namespace }} exec ansible-tower-management -- \
       bash -c "echo 'from django.contrib.auth.models import User; nsu = User.objects.filter(is_superuser=True).count(); exit(0 if nsu > 0 else 1)' | awx-manage shell"
   register: super_check
-  ignore_errors: yes
+  ignore_errors: true
   changed_when: super_check.rc > 0
 
 - name: create django super user if it does not exist
   shell: |
     {{ kubectl_or_oc }} -n {{ kubernetes_namespace }} exec ansible-tower-management -- \
       bash -c "echo \"from django.contrib.auth.models import User; User.objects.create_superuser('{{ admin_user }}', '{{ admin_email }}', '{{ admin_password }}')\" | awx-manage shell"
-  no_log: yes
+  no_log: true
   when: super_check.rc > 0
 
 - name: update django super user password
   shell: |
     {{ kubectl_or_oc }} -n {{ kubernetes_namespace }} exec ansible-tower-management -- \
       bash -c "awx-manage update_password --username='{{ admin_user }}' --password='{{ admin_password }}'"
-  no_log: yes
+  no_log: true
   register: result
   changed_when: "'Password updated' in result.stdout"
 

installer/roles/kubernetes/tasks/openshift.yml

@@ -2,7 +2,7 @@
 - name: Get Project Detail
   shell: "{{ openshift_oc_bin }} get project {{ openshift_project }}"
   register: project_details
-  ignore_errors: yes
+  ignore_errors: true
 
 - name: Create AWX Openshift Project
   shell: "{{ openshift_oc_bin }} new-project {{ openshift_project }}"
@@ -13,7 +13,7 @@
     - name: Check PVC status
       command: "{{ openshift_oc_bin }} get pvc {{ openshift_pg_pvc_name }} -n {{ openshift_project }} -o=jsonpath='{.status.phase}'"
       register: pg_pvc_status
-      ignore_errors: yes
+      ignore_errors: true
 
     - name: Ensure PostgreSQL PVC is available
       assert:

installer/roles/kubernetes/tasks/openshift_auth.yml

@@ -54,4 +54,3 @@
   fail:
     msg: "{{ openshift_auth_result.stderr | default('Invalid token') }}"
   when: openshift_auth_result.rc is defined and openshift_auth_result.rc != 0
-

installer/roles/local_docker/defaults/main.yml

@@ -18,4 +18,3 @@ memcached_image: "memcached"
 memcached_version: "alpine"
 memcached_hostname: "memcached"
 memcached_port: "11211"
-

installer/roles/local_docker/tasks/main.yml

@@ -17,7 +17,7 @@
   file:
     state: directory
     path: "{{ item }}"
-    recurse: yes
+    recurse: true
   when: upgrade_postgres | bool
   with_items:
     - "{{ postgres_data_dir }}/10/data"
@@ -25,7 +25,7 @@
 - name: Stop AWX before upgrading postgres
   docker_service:
     project_src: "{{ docker_compose_dir }}"
-    stopped: yes
+    stopped: true
   when: upgrade_postgres | bool
 
 - name: Upgrade Postgres