Merge pull request #5412 from appuk/apurva-new-ids

Add dataCy attribute

Reviewed-by: https://github.com/apps/softwarefactory-project-zuul
This commit is contained in:
softwarefactory-project-zuul[bot]
2019-12-09 20:22:08 +00:00
committed by GitHub
6 changed files with 24 additions and 5 deletions

View File

@@ -187,11 +187,13 @@ class AddResourceRole extends React.Component {
<SelectableCard <SelectableCard
isSelected={selectedResource === 'users'} isSelected={selectedResource === 'users'}
label={i18n._(t`Users`)} label={i18n._(t`Users`)}
dataCy="add-role-users"
onClick={() => this.handleResourceSelect('users')} onClick={() => this.handleResourceSelect('users')}
/> />
<SelectableCard <SelectableCard
isSelected={selectedResource === 'teams'} isSelected={selectedResource === 'teams'}
label={i18n._(t`Teams`)} label={i18n._(t`Teams`)}
dataCy="add-role-teams"
onClick={() => this.handleResourceSelect('teams')} onClick={() => this.handleResourceSelect('teams')}
/> />
</div> </div>

View File

@@ -33,7 +33,7 @@ const Label = styled.div`
class SelectableCard extends Component { class SelectableCard extends Component {
render() { render() {
const { label, onClick, isSelected } = this.props; const { label, onClick, isSelected, dataCy } = this.props;
return ( return (
<SelectableItem <SelectableItem
@@ -41,6 +41,7 @@ class SelectableCard extends Component {
onKeyPress={onClick} onKeyPress={onClick}
role="button" role="button"
tabIndex="0" tabIndex="0"
data-cy={dataCy}
isSelected={isSelected} isSelected={isSelected}
> >
<Indicator isSelected={isSelected} /> <Indicator isSelected={isSelected} />

View File

@@ -79,7 +79,11 @@ class OrganizationDetail extends Component {
return ( return (
<CardBody> <CardBody>
<DetailList> <DetailList>
<Detail label={i18n._(t`Name`)} value={name} /> <Detail
label={i18n._(t`Name`)}
value={name}
dataCy="organization-detail-name"
/>
<Detail label={i18n._(t`Description`)} value={description} /> <Detail label={i18n._(t`Description`)} value={description} />
<Detail label={i18n._(t`Max Hosts`)} value={`${max_hosts}`} /> <Detail label={i18n._(t`Max Hosts`)} value={`${max_hosts}`} />
<Detail <Detail

View File

@@ -91,7 +91,11 @@ function ProjectDetail({ project, i18n }) {
return ( return (
<CardBody css="padding-top: 20px"> <CardBody css="padding-top: 20px">
<DetailList gutter="sm"> <DetailList gutter="sm">
<Detail label={i18n._(t`Name`)} value={name} /> <Detail
label={i18n._(t`Name`)}
value={name}
dataCy="project-detail-name"
/>
<Detail label={i18n._(t`Description`)} value={description} /> <Detail label={i18n._(t`Description`)} value={description} />
{summary_fields.organization && ( {summary_fields.organization && (
<Detail <Detail

View File

@@ -23,7 +23,11 @@ class TeamDetail extends Component {
return ( return (
<CardBody> <CardBody>
<DetailList> <DetailList>
<Detail label={i18n._(t`Name`)} value={name} /> <Detail
label={i18n._(t`Name`)}
value={name}
dataCy="team-detail-name"
/>
<Detail label={i18n._(t`Description`)} value={description} /> <Detail label={i18n._(t`Description`)} value={description} />
<Detail <Detail
label={i18n._(t`Organization`)} label={i18n._(t`Organization`)}

View File

@@ -42,7 +42,11 @@ class UserDetail extends Component {
return ( return (
<CardBody> <CardBody>
<DetailList> <DetailList>
<Detail label={i18n._(t`Username`)} value={username} /> <Detail
label={i18n._(t`Username`)}
value={username}
dataCy="user-detail-username"
/>
<Detail label={i18n._(t`Email`)} value={email} /> <Detail label={i18n._(t`Email`)} value={email} />
<Detail label={i18n._(t`First Name`)} value={`${first_name}`} /> <Detail label={i18n._(t`First Name`)} value={`${first_name}`} />
<Detail label={i18n._(t`Last Name`)} value={`${last_name}`} /> <Detail label={i18n._(t`Last Name`)} value={`${last_name}`} />