Update Collections Syntax to get Collection related CI Checks Passing (#16061)

* Fix collection task breaking collection ci checks

* Patch ansible.module_utils.basic._ANSIBLE_PROFILE directly

* Conditionalize other santity assertions

* Remove added blank lines and identifier from Fail if absent and no identifier set

awx_collection/tests/integration/targets/schedule/tasks/main.yml

@@ -1,11 +1,11 @@
 ---
 - name: Generate a random string for test
-  set_fact:
+  ansible.builtin.set_fact:
     test_id: "{{ lookup('password', '/dev/null chars=ascii_letters length=16') }}"
   when: test_id is not defined
 
-- name: generate random string for schedule
-  set_fact:
+- name: Generate random string for schedule
+  ansible.builtin.set_fact:
     org_name: "AWX-Collection-tests-organization-org-{{ test_id }}"
     sched1: "AWX-Collection-tests-schedule-sched1-{{ test_id }}"
     sched2: "AWX-Collection-tests-schedule-sched2-{{ test_id }}"
@@ -23,7 +23,8 @@
     host_name: "AWX-Collection-tests-schedule-host-{{ test_id }}"
     slice_num: 10
 
-- block:
+- name: Assert blocks
+  block:
     - name: Try to create without an rrule
       schedule:
         name: "{{ sched1 }}"
@@ -33,7 +34,8 @@
       register: result
       ignore_errors: true
 
-    - assert:
+    - name: Assert result is failed
+      ansible.builtin.assert:
         that:
           - result is failed
           - "'Unable to create schedule '~ sched1 in result.msg"
@@ -59,7 +61,8 @@
       register: result
       ignore_errors: true
 
-    - assert:
+    - name: Unable to create schedule
+      ansible.builtin.assert:
         that:
           - result is failed
           - "'Unable to create schedule '~ sched1 in result.msg"
@@ -72,7 +75,8 @@
         rrule: "DTSTART:20191219T130551Z RRULE:FREQ=WEEKLY;INTERVAL=1;COUNT=1"
       register: result
 
-    - assert:
+    - name: Assert result is changed
+      ansible.builtin.assert:
         that:
           - result is changed
 
@@ -81,7 +85,7 @@
         schedules_enabled_test: "lookup('awx.awx.controller_api', 'schedules/{{result.id}}/').enabled"
 
     - name: Newly created schedules should have API default value for enabled
-      assert:
+      ansible.builtin.assert:
         that:
           - schedules_enabled_test
 
@@ -93,7 +97,8 @@
         rrule: "DTSTART:20191219T130551Z RRULE:FREQ=WEEKLY;INTERVAL=1;COUNT=1"
       register: result
 
-    - assert:
+    - name: Assert result did not change
+      ansible.builtin.assert:
         that:
           - result is not changed
 
@@ -105,7 +110,8 @@
         rrule: "DTSTART:20191219T130551Z RRULE:FREQ=WEEKLY;INTERVAL=1;COUNT=1"
       register: result
 
-    - assert:
+    - name: Assert result changed
+      ansible.builtin.assert:
         that:
           - result is changed
 
@@ -117,7 +123,8 @@
         rrule: "DTSTART:20191219T130551Z RRULE:FREQ=WEEKLY;INTERVAL=1;COUNT=1"
       register: result
 
-    - assert:
+    - name: Assert result changed
+      ansible.builtin.assert:
         that:
           - result is changed
 
@@ -129,7 +136,8 @@
         rrule: "DTSTART:20191219T130551Z RRULE:FREQ=WEEKLY;INTERVAL=1;COUNT=1"
       register: result
 
-    - assert:
+    - name: Assert result changed
+      ansible.builtin.assert:
         that:
           - result is not changed
 
@@ -189,7 +197,8 @@
         state: present
       register: result
 
-    - assert:
+    - name: Assert result changed
+      ansible.builtin.assert:
         that:
           - "result is changed"
 
@@ -264,7 +273,8 @@
       register: result
       ignore_errors: true
 
-    - assert:
+    - name: Assert result changed
+      ansible.builtin.assert:
         that:
           - "result is changed"
 
@@ -281,7 +291,8 @@
       register: result
       ignore_errors: true
 
-    - assert:
+    - name: Assert result changed
+      ansible.builtin.assert:
         that:
           - "result is changed"
 
@@ -293,7 +304,8 @@
         enabled: "false"
       register: result
 
-    - assert:
+    - name: Assert result changed
+      ansible.builtin.assert:
         that:
           - result is changed
 
@@ -322,7 +334,8 @@
       register: result
       ignore_errors: true
 
-    - assert:
+    - name: Assert result failed
+      ansible.builtin.assert:
         that:
           - result is failed
 
@@ -333,7 +346,8 @@
         unified_job_template: "{{ jt2 }}"
       register: result
 
-    - assert:
+    - name: Assert result changed
+      ansible.builtin.assert:
         that:
           - result is changed
 
@@ -345,7 +359,8 @@
       loop:
         - "{{ sched1 }}"
         - "{{ sched2 }}"
-      ignore_errors: True
+      failed_when: >
+        delete_schedules_results is failed
 
     - name: Delete the jt1
       job_template:
@@ -399,7 +414,8 @@
         organization: Default
         credential_type: Red Hat Ansible Automation Platform
         state: absent
-      ignore_errors: True
+      failed_when: >
+        delete_credential1_fails
 
     # Labels can not be deleted
 
@@ -408,7 +424,8 @@
         name: "{{ ee1 }}"
         image: "junk"
         state: absent
-      ignore_errors: True
+      failed_when: >
+        delete_execution_environment_fails
 
     - name: Delete instance groups
       instance_group:
@@ -417,20 +434,23 @@
       loop:
         - "{{ ig1 }}"
         - "{{ ig2 }}"
-      ignore_errors: True
+      failed_when: >
+        delete_instance_groups_fails
 
-    - name: "Remove the organization"
+    - name: Remove the organization
       organization:
         name: "{{ org_name }}"
         state: absent
-      ignore_errors: True
+      failed_when: >
+        remove_org_fails
 
-    - name: "Delete slice inventory"
+    - name: Delete slice inventory
       inventory:
         name: "{{ slice_inventory }}"
         organization: "{{ org_name }}"
         state: absent
-      ignore_errors: True
+      failed_when: >
+        delete_slice_inventory_fails
 
     - name: Delete slice hosts
       host:
@@ -438,4 +458,5 @@
         inventory: "{{ slice_inventory }}"
         state: absent
       loop: "{{ range(slice_num)|list }}"
-      ignore_errors: True
+      failed_when: >
+        delete_slice_hosts_fails