Merge pull request #1378 from rooftopcellist/no_patch_app

disallow changing token-app
This commit is contained in:
Christian Adams
2018-03-09 10:33:24 -05:00
committed by GitHub
2 changed files with 8 additions and 5 deletions

View File

@@ -939,7 +939,6 @@ class UserAuthorizedTokenSerializer(BaseSerializer):
'expires', 'scope', 'application', 'expires', 'scope', 'application',
) )
read_only_fields = ('user', 'token', 'expires') read_only_fields = ('user', 'token', 'expires')
read_only_on_update_fields = ('application',)
def get_token(self, obj): def get_token(self, obj):
request = self.context.get('request', None) request = self.context.get('request', None)
@@ -1106,6 +1105,12 @@ class OAuth2TokenSerializer(BaseSerializer):
return obj return obj
class OAuth2TokenDetailSerializer(OAuth2TokenSerializer):
class Meta:
read_only_fields = ('*', 'user', 'application')
class OAuth2AuthorizedTokenSerializer(BaseSerializer): class OAuth2AuthorizedTokenSerializer(BaseSerializer):
refresh_token = serializers.SerializerMethodField() refresh_token = serializers.SerializerMethodField()
@@ -1118,7 +1123,6 @@ class OAuth2AuthorizedTokenSerializer(BaseSerializer):
'expires', 'scope', 'application', 'expires', 'scope', 'application',
) )
read_only_fields = ('user', 'token', 'expires') read_only_fields = ('user', 'token', 'expires')
read_only_on_update_fields = ('application',)
def get_token(self, obj): def get_token(self, obj):
request = self.context.get('request', None) request = self.context.get('request', None)
@@ -1171,8 +1175,7 @@ class OAuth2PersonalTokenSerializer(BaseSerializer):
'*', '-name', 'description', 'user', 'token', 'refresh_token', '*', '-name', 'description', 'user', 'token', 'refresh_token',
'application', 'expires', 'scope', 'application', 'expires', 'scope',
) )
read_only_fields = ('user', 'token', 'expires') read_only_fields = ('user', 'token', 'expires', 'application')
read_only_on_update_fields = ('application',)
def get_modified(self, obj): def get_modified(self, obj):
if obj is None: if obj is None:

View File

@@ -1587,7 +1587,7 @@ class OAuth2TokenDetail(RetrieveUpdateDestroyAPIView):
view_name = _("OAuth Token Detail") view_name = _("OAuth Token Detail")
model = OAuth2AccessToken model = OAuth2AccessToken
serializer_class = OAuth2TokenSerializer serializer_class = OAuth2TokenDetailSerializer
class OAuth2TokenActivityStreamList(ActivityStreamEnforcementMixin, SubListAPIView): class OAuth2TokenActivityStreamList(ActivityStreamEnforcementMixin, SubListAPIView):