Update RBAC for adding approval nodes

This commit is contained in:
beeankha
2019-08-14 15:10:35 -04:00
committed by Ryan Petrello
parent f7d6f4538c
commit cf436eea37
3 changed files with 10 additions and 5 deletions

View File

@@ -3026,11 +3026,12 @@ class WorkflowJobTemplateNodeCreateApproval(RetrieveAPIView):
return Response(data={'id':approval_template.pk}, status=status.HTTP_200_OK)
def check_permissions(self, request):
obj = self.get_object().workflow_job_template
if request.method == 'POST':
if request.user not in self.get_object().workflow_job_template.admin_role:
if not request.user.can_access(models.WorkflowJobTemplate, 'change', obj, request.data):
self.permission_denied(request)
else:
if request.user not in self.get_object().workflow_job_template.read_role:
if not request.user.can_access(models.WorkflowJobTemplate, 'read', obj):
self.permission_denied(request)
@@ -4487,6 +4488,7 @@ class WorkflowApprovalDeny(RetrieveAPIView):
obj.deny(request)
return Response(status=status.HTTP_204_NO_CONTENT)
# Placeholder code for approval notification support
class WorkflowApprovalNotificationsList(SubListAPIView):