mirror of
https://github.com/ansible/awx.git
synced 2026-03-02 17:28:51 -03:30
fix a bug that prevents launch-time passphrases w/ cred plugins
with the advent of credential plugins there's no way for us to *actually
know* the RSA key value at the time the credential is _created_, because
the order of operations is:
1. Create the credential with a specified passphrase
2. Associate a new dynamic inventory source pointed at some third party
provider (hashi, cyberark, etc...)
this commit removes the code that warns you about an extraneous
passphrase (if you don't specify a private key)
additionally, the code for determining whether or not a credential
_requires_ a password/phrase at launch time has been updated to test
private key validity based on the *actual* value from the third party
provider
see: https://github.com/ansible/awx/issues/4791
This commit is contained in:
@@ -151,7 +151,7 @@ class Credential(PasswordFieldsModel, CommonModelNameNotUnique, ResourceMixin):
|
||||
@property
|
||||
def has_encrypted_ssh_key_data(self):
|
||||
try:
|
||||
ssh_key_data = decrypt_field(self, 'ssh_key_data')
|
||||
ssh_key_data = self.get_input('ssh_key_data')
|
||||
except AttributeError:
|
||||
return False
|
||||
|
||||
@@ -633,9 +633,6 @@ ManagedCredentialType(
|
||||
'secret': True,
|
||||
'ask_at_runtime': True
|
||||
}],
|
||||
'dependencies': {
|
||||
'ssh_key_unlock': ['ssh_key_data'],
|
||||
}
|
||||
}
|
||||
)
|
||||
|
||||
@@ -667,9 +664,6 @@ ManagedCredentialType(
|
||||
'type': 'string',
|
||||
'secret': True
|
||||
}],
|
||||
'dependencies': {
|
||||
'ssh_key_unlock': ['ssh_key_data'],
|
||||
}
|
||||
}
|
||||
)
|
||||
|
||||
@@ -738,7 +732,6 @@ ManagedCredentialType(
|
||||
'secret': True,
|
||||
}],
|
||||
'dependencies': {
|
||||
'ssh_key_unlock': ['ssh_key_data'],
|
||||
'authorize_password': ['authorize'],
|
||||
},
|
||||
'required': ['username'],
|
||||
|
||||
Reference in New Issue
Block a user