From da951714d1c3f29ed30e6cb00c20d70cb0418232 Mon Sep 17 00:00:00 2001 From: Alex Corey Date: Fri, 11 Jun 2021 11:48:51 -0400 Subject: [PATCH] resolves iinfinite loop --- .../src/components/AssociateModal/AssociateModal.test.jsx | 1 + .../src/screens/InstanceGroup/Instances/InstanceList.jsx | 6 ++++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/awx/ui_next/src/components/AssociateModal/AssociateModal.test.jsx b/awx/ui_next/src/components/AssociateModal/AssociateModal.test.jsx index d624f683d2..18174f8b08 100644 --- a/awx/ui_next/src/components/AssociateModal/AssociateModal.test.jsx +++ b/awx/ui_next/src/components/AssociateModal/AssociateModal.test.jsx @@ -54,6 +54,7 @@ describe('', () => { test('should fetch and render list items', () => { expect(fetchRequest).toHaveBeenCalledTimes(1); + expect(optionsRequest).toHaveBeenCalledTimes(1); expect(wrapper.find('CheckboxListItem').length).toBe(3); }); diff --git a/awx/ui_next/src/screens/InstanceGroup/Instances/InstanceList.jsx b/awx/ui_next/src/screens/InstanceGroup/Instances/InstanceList.jsx index e66a13457e..6caa945f25 100644 --- a/awx/ui_next/src/screens/InstanceGroup/Instances/InstanceList.jsx +++ b/awx/ui_next/src/screens/InstanceGroup/Instances/InstanceList.jsx @@ -141,8 +141,10 @@ function InstanceList() { [instanceGroupId] ); - const readInstancesOptions = () => - InstanceGroupsAPI.readInstanceOptions(instanceGroupId); + const readInstancesOptions = useCallback( + () => InstanceGroupsAPI.readInstanceOptions(instanceGroupId), + [instanceGroupId] + ); return ( <>