From dce52d05525759889d0bcda68b01d37a38f988e4 Mon Sep 17 00:00:00 2001 From: Marliana Lara Date: Tue, 1 May 2018 14:14:28 -0400 Subject: [PATCH] Update the Add button content and styles * Change the text from "Add" to "+" * Update the e2e test to check for an id #button-add --- awx/ui/client/features/_index.less | 1 - .../applications/list-applications.view.html | 1 + awx/ui/client/features/credentials/_index.less | 3 --- .../features/credentials/legacy.credentials.js | 4 ++-- .../features/templates/templates.strings.js | 1 - .../features/templates/templatesList.view.html | 6 ++---- .../users/tokens/users-tokens-list.partial.html | 1 + awx/ui/client/legacy/styles/ansible-ui.less | 6 ++++-- awx/ui/client/legacy/styles/lists.less | 17 +++-------------- awx/ui/client/lib/components/list/_index.less | 11 ----------- awx/ui/client/lib/theme/_global.less | 5 +++-- .../credential-types/credential-types.list.js | 4 ++-- .../client/src/credentials/credentials.form.js | 5 +++-- .../client/src/credentials/credentials.list.js | 4 ++-- .../instances/instances-list.partial.html | 1 + .../list/instance-groups-list.partial.html | 1 + .../related/groups/hosts-related-groups.list.js | 4 ++-- .../inventories/inventory.list.js | 4 ++-- .../inventories/related/groups/groups.list.js | 4 ++-- .../nested-groups/group-nested-groups.list.js | 4 ++-- .../nested-hosts/group-nested-hosts.list.js | 4 ++-- .../related/hosts/related-host.list.js | 4 ++-- .../nested-groups/host-nested-groups.list.js | 4 ++-- .../inventories/related/sources/sources.list.js | 4 ++-- .../smart-inventory/smart-inventory.form.js | 4 ++-- .../standard-inventory/inventory.form.js | 4 ++-- .../inventory-scripts/inventory-scripts.list.js | 4 ++-- .../notifications/notificationTemplates.list.js | 4 ++-- .../linkout/organizations-linkout.route.js | 7 +++---- .../list/organizations-list.partial.html | 7 +++---- .../src/organizations/organizations.form.js | 4 ++-- .../src/organizations/organizations.list.js | 4 ++-- awx/ui/client/src/projects/projects.form.js | 4 ++-- awx/ui/client/src/projects/projects.list.js | 4 ++-- awx/ui/client/src/scheduler/schedules.list.js | 4 ++-- awx/ui/client/src/shared/generator-helpers.js | 1 + .../list-generator/list-actions.partial.html | 12 ++++++------ awx/ui/client/src/teams/teams.form.js | 8 ++++---- awx/ui/client/src/teams/teams.list.js | 4 ++-- .../job_templates/job-template.form.js | 4 ++-- awx/ui/client/src/templates/templates.list.js | 4 ++-- awx/ui/client/src/templates/workflows.form.js | 4 ++-- awx/ui/client/src/users/users.form.js | 4 ++-- awx/ui/client/src/users/users.list.js | 4 ++-- awx/ui/test/e2e/objects/credentialTypes.js | 2 +- awx/ui/test/e2e/objects/credentials.js | 2 +- awx/ui/test/e2e/objects/inventories.js | 6 +++--- awx/ui/test/e2e/objects/inventoryScripts.js | 2 +- .../test/e2e/objects/notificationTemplates.js | 2 +- awx/ui/test/e2e/objects/organizations.js | 2 +- awx/ui/test/e2e/objects/projects.js | 2 +- awx/ui/test/e2e/objects/sections/permissions.js | 2 +- awx/ui/test/e2e/objects/teams.js | 2 +- awx/ui/test/e2e/objects/templates.js | 4 ++-- awx/ui/test/e2e/objects/users.js | 2 +- awx/ui/test/e2e/tests/smoke.js | 5 ++--- 56 files changed, 104 insertions(+), 127 deletions(-) delete mode 100644 awx/ui/client/features/credentials/_index.less diff --git a/awx/ui/client/features/_index.less b/awx/ui/client/features/_index.less index 59e8e4630b..04be5b31bb 100644 --- a/awx/ui/client/features/_index.less +++ b/awx/ui/client/features/_index.less @@ -1,3 +1,2 @@ -@import 'credentials/_index'; @import 'output/_index'; @import 'users/tokens/_index'; diff --git a/awx/ui/client/features/applications/list-applications.view.html b/awx/ui/client/features/applications/list-applications.view.html index 1803e5ab66..1dd96b2dc1 100644 --- a/awx/ui/client/features/applications/list-applications.view.html +++ b/awx/ui/client/features/applications/list-applications.view.html @@ -23,6 +23,7 @@ type="button" ui-sref="applications.add" class="at-Button--add" + id="button-add" aria-haspopup="true" aria-expanded="false"> diff --git a/awx/ui/client/features/credentials/_index.less b/awx/ui/client/features/credentials/_index.less deleted file mode 100644 index 87f746b2c3..0000000000 --- a/awx/ui/client/features/credentials/_index.less +++ /dev/null @@ -1,3 +0,0 @@ -.at-CredentialsPermissions { - margin-top: 50px; -} diff --git a/awx/ui/client/features/credentials/legacy.credentials.js b/awx/ui/client/features/credentials/legacy.credentials.js index 07cee1329d..27428feb7b 100644 --- a/awx/ui/client/features/credentials/legacy.credentials.js +++ b/awx/ui/client/features/credentials/legacy.credentials.js @@ -69,8 +69,8 @@ function LegacyCredentialsService () { ngClick: '$state.go(\'.add\')', label: 'Add', awToolTip: N_('Add a permission'), - actionClass: 'btn List-buttonSubmit', - buttonContent: `+ ${N_('ADD')}`, + actionClass: 'at-Button--add', + actionId: 'button-add', ngShow: '(credential_obj.summary_fields.user_capabilities.edit || canAdd)' } }, diff --git a/awx/ui/client/features/templates/templates.strings.js b/awx/ui/client/features/templates/templates.strings.js index 896cfd87bd..3bb2d38b66 100644 --- a/awx/ui/client/features/templates/templates.strings.js +++ b/awx/ui/client/features/templates/templates.strings.js @@ -10,7 +10,6 @@ function TemplatesStrings (BaseString) { ns.list = { PANEL_TITLE: t.s('TEMPLATES'), - ADD_BUTTON_LABEL: t.s('ADD'), ADD_DD_JT_LABEL: t.s('Job Template'), ADD_DD_WF_LABEL: t.s('Workflow Template'), ROW_ITEM_LABEL_ACTIVITY: t.s('Activity'), diff --git a/awx/ui/client/features/templates/templatesList.view.html b/awx/ui/client/features/templates/templatesList.view.html index e68ddef8fb..2608a04177 100644 --- a/awx/ui/client/features/templates/templatesList.view.html +++ b/awx/ui/client/features/templates/templatesList.view.html @@ -14,13 +14,11 @@