From dd5f25186b26ac3ae9b3861be3cfb18d71699afa Mon Sep 17 00:00:00 2001 From: mabashian Date: Tue, 10 Mar 2020 13:31:55 -0400 Subject: [PATCH] Fixes bug where user with edit permissions on a credential but no permissions on the credentials org would be denied access to the form in the UI. --- .../features/credentials/add-edit-credentials.controller.js | 2 +- awx/ui/client/features/credentials/index.js | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/awx/ui/client/features/credentials/add-edit-credentials.controller.js b/awx/ui/client/features/credentials/add-edit-credentials.controller.js index 3c9ea31fe9..ad8db51751 100644 --- a/awx/ui/client/features/credentials/add-edit-credentials.controller.js +++ b/awx/ui/client/features/credentials/add-edit-credentials.controller.js @@ -72,7 +72,7 @@ function AddEditCredentialsController ( vm.form.credential_type._displayValue = credentialType.get('name'); vm.isTestable = (isEditable && credentialType.get('kind') === 'external'); - if (credential.get('related.input_sources.results.length' > 0)) { + if (credential.get('related.input_sources.results').length > 0) { vm.form.credential_type._disabled = true; } diff --git a/awx/ui/client/features/credentials/index.js b/awx/ui/client/features/credentials/index.js index 1bdec18f93..c0f28f5dc2 100644 --- a/awx/ui/client/features/credentials/index.js +++ b/awx/ui/client/features/credentials/index.js @@ -40,7 +40,6 @@ function CredentialsResolve ( return $q.all(promises) .then(models => { const typeId = models.credential.get('credential_type'); - const orgId = models.credential.get('organization'); Rest.setUrl(GetBasePath('credentials')); const params = { target_input_sources__target_credential: id }; @@ -48,7 +47,9 @@ function CredentialsResolve ( const dependents = { credentialType: new CredentialType('get', typeId), - organization: new Organization('get', orgId), + organization: new Organization('get', { + resource: models.credential.get('summary_fields.organization') + }), credentialInputSources: models.credential.extend('GET', 'input_sources'), sourceCredentials: sourceCredentialsPromise };