External-Mirrors/awx
2
0
Fork 0
mirror of https://github.com/ansible/awx.git synced 2026-03-14 23:47:28 -02:30
Code Issues Packages Projects Releases Wiki Activity

Update serializers to remove empty choices, provide default values for fields, and better indicate the field type when possible for OPTIONS requests and browsable API docs.

Browse Source
This commit is contained in:
Chris Church
2015-05-11 18:25:30 -04:00
parent 27b06313a7
commit e017270201
6 changed files with 73 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
awx/api/generics.py
View File

@@ -217,7 +217,7 @@ class GenericAPIView(generics.GenericAPIView, APIView):
for field, meta in fields.items():
if not isinstance(meta, dict):
continue
if meta.get('read_only', False):
if meta.pop('read_only', False):
fields.pop(field)
if 'GET' in self.allowed_methods:
cloned_request = clone_request(request, 'GET')
@@ -242,12 +242,19 @@ class GenericAPIView(generics.GenericAPIView, APIView):
serializer = self.get_serializer()
actions['GET'] = serializer.metadata()
if hasattr(serializer, 'get_types'):
# Inject the type field choices into GET options as well as on
# the metadata itself.
if 'type' in actions['GET']:
actions['GET']['type']['type'] = 'multiple choice'
actions['GET']['type']['choices'] = serializer.get_type_choices()
ret['types'] = serializer.get_types()
# Remove fields labeled as write_only, remove field attributes
# that aren't relevant for retrieving data.
for field, meta in actions['GET'].items():
if not isinstance(meta, dict):
continue
meta.pop('required', None)
meta.pop('read_only', None)
meta.pop('default', None)
meta.pop('min_length', None)
meta.pop('max_length', None)
if meta.pop('write_only', False):
actions['GET'].pop(field)
if actions:
ret['actions'] = actions
if getattr(self, 'search_fields', None):