External-Mirrors/awx
2
0
Fork 0
mirror of https://github.com/ansible/awx.git synced 2026-02-15 10:10:01 -03:30
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #12156 from mabashian/large-workflow-crash

Browse Source 
Don't repeatedly traverse workflow nodes when finding ancestors
This commit is contained in:
JST
2022-05-10 14:41:49 -03:00
committed by GitHub
parent dfea9cc526 703a68d4fe
commit e87c121f8f
1 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
awx/ui/src/components/Workflow/workflowReducer.js
View File

@@ -548,17 +548,21 @@ function selectSourceForLinking(state, sourceNode) {
invalidLinkTargetIds.push(link.target.id); invalidLinkTargetIds.push(link.target.id);
} }
if (!parentMap[link.target.id]) { if (!parentMap[link.target.id]) {
parentMap[link.target.id] = []; parentMap[link.target.id] = {
parents: [],
traversed: false,
};
} }
parentMap[link.target.id].push(link.source.id); parentMap[link.target.id].parents.push(link.source.id);
}); });
const getAncestors = (id) => { const getAncestors = (id) => {
if (parentMap[id]) { if (parentMap[id] && !parentMap[id].traversed) {
parentMap[id].forEach((parentId) => { parentMap[id].parents.forEach((parentId) => {
invalidLinkTargetIds.push(parentId); invalidLinkTargetIds.push(parentId);
getAncestors(parentId); getAncestors(parentId);
}); });
parentMap[id].traversed = true;
} }
}; };