Merge pull request #32 from marshmalien/ux/fix/inventory

UX Hit List: Inventories, Empty Lists, Lookup Buttons

awx/ui/client/legacy-styles/ansible-ui.less

@@ -728,7 +728,6 @@ dd {
 }
 
 .error {
-  margin-top: 5px;
   font-size: 12px;
   line-height: normal;
   color: @red;

awx/ui/client/legacy-styles/forms.less

@@ -464,7 +464,6 @@
 .Form-lookupButton:hover {
     cursor: pointer;
     background-color: @field-lookup-btn-hov-bg;
-    border: 1px solid @field-border;
     color: @default-interface-txt;
 }
 

awx/ui/client/legacy-styles/jobs.less

@@ -59,6 +59,10 @@
         background-color: @white;
     }
 
+    .List-noItems {
+        margin-top: 0;
+    }
+
 }
 
 @media (min-width: 1201px) {

awx/ui/client/src/inventories-hosts/hosts/host.form.js

@@ -79,11 +79,6 @@ function(i18n) {
                     dataTitle: i18n._('Host Variables'),
                     dataPlacement: 'right',
                     dataContainer: 'body'
-                },
-                inventory: {
-                    type: 'hidden',
-                    includeOnEdit: true,
-                    includeOnAdd: true
                 }
             },
 

awx/ui/client/src/inventories-hosts/inventories/inventories.block.less

@@ -1,3 +1,12 @@
 .Inventories-hostStatus {
     margin-left: 5px;
 }
+#inventories-panel {
+    .completed_jobsList.List-well {
+        margin: 0;
+
+        .List-noItems {
+            margin: 0;
+        }
+    }
+}

awx/ui/client/src/inventories-hosts/inventories/related/completed-jobs/completed-jobs.list.js

@@ -19,7 +19,7 @@ export default ['i18n', function(i18n) {
         editTitle: i18n._('COMPLETED JOBS'),
         index: false,
         hover: true,
-        well: false,
+        well: true,
         emptyListText: i18n._('No completed jobs'),
 
         fields: {

awx/ui/client/src/inventories-hosts/inventories/related/groups/related/nested-hosts/group-nested-hosts.form.js

@@ -79,11 +79,6 @@ function(i18n) {
                     dataTitle: i18n._('Host Variables'),
                     dataPlacement: 'right',
                     dataContainer: 'body'
-                },
-                inventory: {
-                    type: 'hidden',
-                    includeOnEdit: true,
-                    includeOnAdd: true
                 }
             },
 

awx/ui/client/src/inventories-hosts/inventory-hosts.block.less

@@ -0,0 +1,10 @@
+#hosts-panel {
+    .List-noItems {
+        margin-top: 0px;
+    }
+    .groupsList {
+        .List-noItems {
+            margin-top: 52px;
+        }
+    }
+}

awx/ui/client/src/organizations/organizations.block.less

@@ -0,0 +1,5 @@
+#organizations {
+    .List-noItems {
+        margin-top: 20px;
+    }
+}

awx/ui/client/src/shared/form-generator.js

@@ -740,18 +740,10 @@ angular.module('FormGenerator', [GeneratorHelpers.name, 'Utilities', listGenerat
                     html += "</div>\n";
                 }
 
-                if (field.type === 'hidden') {
-                    if ((options.mode === 'edit' && field.includeOnEdit) ||
-                        (options.mode === 'add' && field.includeOnAdd)) {
-                        html += "<input type=\"hidden\" ng-model=\"" + fld + "\" name=\"" + fld + "\" />";
-                    }
-                }
-
                 if ((!field.readonly) || (field.readonly && options.mode === 'edit')) {
 
                     if((field.excludeMode === undefined || field.excludeMode !== options.mode) && field.type !== 'alertblock' && field.type !== 'workflow-chart') {
 
-
                     html += "<div class='form-group Form-formGroup ";
                     html += (field.disabled) ? `Form-formGroup--disabled ` : ``;
                     html += (field.type === "checkbox") ? "Form-formGroup--checkbox" : "";