From e9aa3f78e2498ff0bbdf6fd5907d7b3f48c89e86 Mon Sep 17 00:00:00 2001 From: Chris Church Date: Thu, 4 Apr 2013 14:47:10 -0400 Subject: [PATCH] Removed todo/comments that have been implemented. --- TODO.md | 2 -- lib/main/models/__init__.py | 15 +-------------- 2 files changed, 1 insertion(+), 16 deletions(-) diff --git a/TODO.md b/TODO.md index c79c8c4004..86274a85b5 100644 --- a/TODO.md +++ b/TODO.md @@ -7,8 +7,6 @@ TODO items for ansible commander * host relationships in DB, last launch job status per host, etc (self.play.inventory) <- Chris * stats attributes on launch job (??) * make launch job rest triggerable & launch job statuses readable. launch_job.start() <-- MPD -* Chris ---- callback plugin calls external script <-- Chris - ansible_delegate_callback calls ACOM_DATABASE_LOGGER script ? * do we need something other than default playbook (ProjectOptions) <-- BOTH, TBD * way to send cntrl-c to kill job (method on job?) <-- Chris, low priority * documentation on how to run with callbacks from NOT a launchjob <-- Chris diff --git a/lib/main/models/__init__.py b/lib/main/models/__init__.py index 9d5bd0fb91..376b6a6758 100644 --- a/lib/main/models/__init__.py +++ b/lib/main/models/__init__.py @@ -725,20 +725,14 @@ class LaunchJob(CommonModel): # project has one default playbook but really should have a list of playbooks and flags ... - - # ENOUGH_TO_RUN_DJANGO=foo ACOM_INVENTORY_ID= ansible-playbook -i ansible-commander-inventory.py - # ^-- this is a hard coded path # ssh-agent bash # ssh-add ... < key entry # - # inventory script I can write, and will use ACOM_INVENTORY_ID - # - # # playbook in source control is already on the disk # job_type: # run, check -- enough for now, more initially - # if check, add "--check" to parameters + # if check, add "--check" to parameters # we'll extend ansible core to have callback context like # self.context.playbook @@ -746,19 +740,12 @@ class LaunchJob(CommonModel): # and the callback will read the environment for ACOM_CELERY_JOB_ID or similar # and log tons into the database - # we'll also log stdout/stderr somewhere for debugging - # the ansible commander setup instructions will include installing the database logging callback # inventory script is going to need some way to load Django models # it is documented on ansible.cc under API docs and takes two parameters # --list # -- host - # posting the LaunchJob should return some type of resource that we can check for status - # that all the log data will use as a Foreign Key - -# TODO: Events - class LaunchJobStatus(CommonModel): ''' Status for a single run of a launch job.