From ea1c4ee1d54c125286e5b7a7d1e043a83ba74114 Mon Sep 17 00:00:00 2001 From: Wayne Witzel III Date: Mon, 13 Mar 2017 18:13:55 -0400 Subject: [PATCH] correct unintentional stripping of - from order by fields --- awx/api/filters.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/awx/api/filters.py b/awx/api/filters.py index fbd7a0ba64..6d5c7920c5 100644 --- a/awx/api/filters.py +++ b/awx/api/filters.py @@ -339,12 +339,12 @@ class OrderByBackend(BaseFilterBackend): def _strip_sensitive_model_fields(self, model, order_by): for field_name in order_by: # strip off the negation prefix `-` if it exists - field_name = field_name.split('-')[-1] + _field_name = field_name.split('-')[-1] try: # if the field name is encrypted/sensitive, don't sort on it - if field_name in getattr(model, 'PASSWORD_FIELDS', ()) or \ - getattr(model._meta.get_field(field_name), '__prevent_search__', False): - raise ParseError(_('cannot order by field %s') % field_name) + if _field_name in getattr(model, 'PASSWORD_FIELDS', ()) or \ + getattr(model._meta.get_field(_field_name), '__prevent_search__', False): + raise ParseError(_('cannot order by field %s') % _field_name) except FieldDoesNotExist: pass yield field_name