From ea80e244b9575c1c29682426c491e2a6a0020c3d Mon Sep 17 00:00:00 2001 From: chris meyers Date: Thu, 1 Nov 2018 12:45:17 -0400 Subject: [PATCH] remove relationship in view if cycle detected --- awx/api/views/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/awx/api/views/__init__.py b/awx/api/views/__init__.py index ee4959d9f2..9feab18b47 100644 --- a/awx/api/views/__init__.py +++ b/awx/api/views/__init__.py @@ -2951,12 +2951,12 @@ class WorkflowJobTemplateNodeChildrenBaseList(WorkflowsEnforcementMixin, Enforce parent_node_type_relationship = getattr(parent, self.relationship) parent_node_type_relationship.add(sub) - parent.save() graph = WorkflowDAG(parent.workflow_job_template) if graph.has_cycle(): parent_node_type_relationship.remove(sub) return {"Error": _("Cycle detected.")} + parent_node_type_relationship.remove(sub) return None