From e62c77e7837f3b6ebb95ab3c128a9dbfdfe0049d Mon Sep 17 00:00:00 2001 From: nixocio Date: Mon, 6 Jun 2022 13:11:18 -0400 Subject: [PATCH] Add typeahed for single choice surveys Add typeahed for single choice surveys, also fix a couple of missing translations for Select component. See: https://github.com/ansible/awx/issues/8097 --- awx/ui/src/components/LaunchPrompt/steps/SurveyStep.js | 2 +- awx/ui/src/components/MultiSelect/TagMultiSelect.js | 1 + .../Credential/shared/CredentialFormFields/BecomeMethodField.js | 1 + awx/ui/src/screens/Template/Survey/SurveyListItem.js | 2 +- 4 files changed, 4 insertions(+), 2 deletions(-) diff --git a/awx/ui/src/components/LaunchPrompt/steps/SurveyStep.js b/awx/ui/src/components/LaunchPrompt/steps/SurveyStep.js index 2444580919..9e526c984b 100644 --- a/awx/ui/src/components/LaunchPrompt/steps/SurveyStep.js +++ b/awx/ui/src/components/LaunchPrompt/steps/SurveyStep.js @@ -122,7 +122,7 @@ function MultipleChoiceField({ question }) { setIsOpen(false); }} selections={field.value} - variant={SelectVariant.single} + variant={SelectVariant.typeahead} id={id} ouiaId={`single-survey-question-${question.variable}`} isOpen={isOpen} diff --git a/awx/ui/src/components/MultiSelect/TagMultiSelect.js b/awx/ui/src/components/MultiSelect/TagMultiSelect.js index d4c92de4d2..b6b21c3663 100644 --- a/awx/ui/src/components/MultiSelect/TagMultiSelect.js +++ b/awx/ui/src/components/MultiSelect/TagMultiSelect.js @@ -59,6 +59,7 @@ function TagMultiSelect({ onChange, value }) { typeAheadAriaLabel={t`Select tags`} noResultsFoundText={t`No results found`} ouiaId="tag-multiselect" + createText={t`Create`} > {renderOptions(options)} diff --git a/awx/ui/src/screens/Credential/shared/CredentialFormFields/BecomeMethodField.js b/awx/ui/src/screens/Credential/shared/CredentialFormFields/BecomeMethodField.js index 82eee49f87..974f52a900 100644 --- a/awx/ui/src/screens/Credential/shared/CredentialFormFields/BecomeMethodField.js +++ b/awx/ui/src/screens/Credential/shared/CredentialFormFields/BecomeMethodField.js @@ -63,6 +63,7 @@ function BecomeMethodField({ fieldOptions, isRequired }) { setOptions([...options, { value: option }]); }} noResultsFoundText={t`No results found`} + createText={t`Create`} > {options.map((option) => ( diff --git a/awx/ui/src/screens/Template/Survey/SurveyListItem.js b/awx/ui/src/screens/Template/Survey/SurveyListItem.js index bca3d5a4c3..273d92af0c 100644 --- a/awx/ui/src/screens/Template/Survey/SurveyListItem.js +++ b/awx/ui/src/screens/Template/Survey/SurveyListItem.js @@ -44,7 +44,7 @@ function SurveyListItem({ canEdit, question, isChecked, onSelect, rowIndex }) { question.variable )}`} > - {question.question_name} + {question.question_name} {question.required && (