Merge pull request #6568 from AlanCoding/whoops_not_changed

Do not set changed=True if the object did not change

Reviewed-by: https://github.com/apps/softwarefactory-project-zuul

awx_collection/plugins/modules/tower_credential_type.py

@@ -123,9 +123,10 @@ def main():
     # These will be passed into the create/updates
     credential_type_params = {
         'name': new_name if new_name else name,
-        'kind': kind,
         'managed_by_tower': False,
     }
+    if kind:
+        credential_type_params['kind'] = kind
     if module.params.get('description'):
         credential_type_params['description'] = module.params.get('description')
     if module.params.get('inputs'):

awx_collection/plugins/modules/tower_job_template.py

@@ -450,6 +450,8 @@ def main():
             existing_spec = module.get_endpoint(spec_endpoint)['json']
         if new_spec != existing_spec:
             module.json_output['changed'] = True
+            if existing_item and module.has_encrypted_values(existing_spec):
+                module._encrypted_changed_warning('survey_spec', existing_item, warning=True)
             on_change = update_survey
 
     if state == 'absent':

awx_collection/plugins/modules/tower_workflow_job_template.py

@@ -209,6 +209,8 @@ def main():
             existing_spec = module.get_endpoint(spec_endpoint)
         if new_spec != existing_spec:
             module.json_output['changed'] = True
+            if existing_item and module.has_encrypted_values(existing_spec):
+                module._encrypted_changed_warning('survey_spec', existing_item, warning=True)
             on_change = update_survey
 
     if state == 'absent':