External-Mirrors/awx
2
0
Fork 0
mirror of https://github.com/ansible/awx.git synced 2026-03-20 18:37:39 -02:30
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2716 from ryanpetrello/fix-fail-workflow-on-missing-jt

Browse Source 
set workflow status to failed if we find a node w/ a missing UJT
This commit is contained in:
Ryan Petrello
2018-07-31 08:19:39 -04:00
committed by GitHub
parent cc574be657 184db58fa3
commit ef242483b3
2 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
awx/main/scheduler/dag_workflow.py
View File

@@ -69,6 +69,7 @@ class WorkflowDAG(SimpleDAG):
job = obj.job job = obj.job
if obj.unified_job_template is None: if obj.unified_job_template is None:
is_failed = True
continue continue
elif not job: elif not job:
return False, False return False, False

9
awx/main/tests/functional/models/test_workflow.py
View File

@@ -61,6 +61,15 @@ class TestWorkflowDAGFunctional(TransactionTestCase):
self.assertTrue(is_done) self.assertTrue(is_done)
self.assertFalse(has_failed) self.assertFalse(has_failed)
# verify that relaunched WFJ fails if a JT leaf is deleted
for jt in JobTemplate.objects.all():
jt.delete()
relaunched = wfj.create_relaunch_workflow_job()
dag = WorkflowDAG(workflow_job=relaunched)
is_done, has_failed = dag.is_workflow_done()
self.assertTrue(is_done)
self.assertTrue(has_failed)
def test_workflow_fails_for_unfinished_node(self): def test_workflow_fails_for_unfinished_node(self):
wfj = self.workflow_job(states=['error', None, None, None, None]) wfj = self.workflow_job(states=['error', None, None, None, None])
dag = WorkflowDAG(workflow_job=wfj) dag = WorkflowDAG(workflow_job=wfj)