mirror of
https://github.com/ansible/awx.git
synced 2026-05-14 21:07:39 -02:30
Reduce number of requests running in the try/except block
This commit is contained in:
@@ -125,11 +125,13 @@ def update_fields(module, p):
|
|||||||
job_template = params.get('job_template')
|
job_template = params.get('job_template')
|
||||||
extra_vars = params.get('extra_vars')
|
extra_vars = params.get('extra_vars')
|
||||||
try:
|
try:
|
||||||
ask_extra_vars = tower_cli.get_resource('job_template').get(name=job_template)['ask_variables_on_launch']
|
job_template_to_launch = tower_cli.get_resource('job_template').get(name=job_template)
|
||||||
survey_enabled = tower_cli.get_resource('job_template').get(name=job_template)['survey_enabled']
|
|
||||||
except (exc.NotFound) as excinfo:
|
except (exc.NotFound) as excinfo:
|
||||||
module.fail_json(msg='Unable to launch job, job_template/{0} was not found: {1}'.format(job_template, excinfo), changed=False)
|
module.fail_json(msg='Unable to launch job, job_template/{0} was not found: {1}'.format(job_template, excinfo), changed=False)
|
||||||
|
|
||||||
|
ask_extra_vars = job_template_to_launch['ask_variables_on_launch']
|
||||||
|
survey_enabled = job_template_to_launch['survey_enabled']
|
||||||
|
|
||||||
if extra_vars and (ask_extra_vars or survey_enabled):
|
if extra_vars and (ask_extra_vars or survey_enabled):
|
||||||
params_update['extra_vars'] = [json.dumps(extra_vars)]
|
params_update['extra_vars'] = [json.dumps(extra_vars)]
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user